Re: [Qemu-devel] [PATCH 01/10] roms: lift "edk2-funcs.sh" from "tests/uefi-test-tools/build.sh"

[Laszlo Ersek]

On 03/11/19 13:11, Eric Blake wrote:
> On 3/11/19 7:07 AM, Eric Blake wrote:
>> On 3/8/19 6:48 PM, Laszlo Ersek wrote:
>>> Extract the dense logic for architecture and toolchain massaging from
>>> "tests/uefi-test-tools/build.sh", to a set of small functions. We'll reuse
>>> these functions for building full platform firmware images.
>>>
> 
> 
>>> +++ b/tests/uefi-test-tools/build.sh
>>> @@ -38,97 +38,12 @@ if [ $ret -ne 0 ]; then
>>
>> build.sh is already marked as a bash script, and...
>>
>>> +# Fetch some option arguments, and set the cross-compilation environment 
>>> (if
>>> +# any), for the edk2 "build" utility.
>>> +source "$edk2_dir/../edk2-funcs.sh"
>>
>> you are only ever sourcing the file, rather than directly executing it
>> as a standalone script.
> 
> Except that later, you have a patch that sources the file from non-bash.
> See my followup on 7/10. :(
> 

Right, thanks for that; there I proposed SHELL=/bin/bash (for the fix
that I should add).

Thanks
Laszlo