[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 11/26] tests/tcg/mips: fix hello-mips compilation
From: |
Alex Bennée |
Subject: |
[Qemu-devel] [PULL 11/26] tests/tcg/mips: fix hello-mips compilation |
Date: |
Tue, 12 Mar 2019 17:09:16 +0000 |
The compilation flags for proper building are in the source tree. We
also fix exit to 0 so the result is counted as a success.
Signed-off-by: Alex Bennée <address@hidden>
diff --git a/tests/tcg/mips/Makefile.target b/tests/tcg/mips/Makefile.target
index 086625f533..1a994d5525 100644
--- a/tests/tcg/mips/Makefile.target
+++ b/tests/tcg/mips/Makefile.target
@@ -8,15 +8,12 @@ MIPS_SRC=$(SRC_PATH)/tests/tcg/mips
# Set search path for all sources
VPATH += $(MIPS_SRC)
+# hello-mips is 32 bit only
+ifeq ($(findstring 64,$(TARGET_NAME)),)
MIPS_TESTS=hello-mips
TESTS += $(MIPS_TESTS)
-hello-mips: CFLAGS+=-ffreestanding
+hello-mips: CFLAGS+=-mno-abicalls -fno-PIC -mabi=32
hello-mips: LDFLAGS+=-nostdlib
-
-# For MIPS32 and 64 we have a bunch of extra tests in sub-directories
-# however they are intended for system tests.
-
-run-hello-mips: hello-mips
- $(call skip-test, $<, "BROKEN")
+endif
diff --git a/tests/tcg/mips/hello-mips.c b/tests/tcg/mips/hello-mips.c
index c7052fdf2e..4e1cf501af 100644
--- a/tests/tcg/mips/hello-mips.c
+++ b/tests/tcg/mips/hello-mips.c
@@ -60,5 +60,5 @@ static inline int write(int fd, const char *buf, int len)
void __start(void)
{
write (1, "Hello, World!\n", 14);
- exit1 (42);
+ exit1(0);
}
--
2.20.1
- [Qemu-devel] [PULL 19/26] tests/tcg/cris: align mul operations, (continued)
- [Qemu-devel] [PULL 19/26] tests/tcg/cris: align mul operations, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 25/26] .travis.yml: separate softfloat from check-tcg, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 13/26] tests/tcg/xtensa: enable system tests, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 06/26] tests/tcg: add softmmu awareness to Makefile, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 03/26] .travis.yml: reduce the module builds to major architectures, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 01/26] travis: Bump Xcode 10 image to 10.2, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 02/26] .travis.yml: combine docs and tools build with out-of-tree, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 09/26] tests/tcg: split run-test into user and system variants, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 16/26] tests/tcg/cris: cleanup sys.c, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 15/26] tests/docker: add fedora-cris-cross compilers, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 11/26] tests/tcg/mips: fix hello-mips compilation,
Alex Bennée <=
- [Qemu-devel] [PULL 14/26] tests/tcg/arm: add ARMv6-M UNDEFINED 32-bit instruction test, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 10/26] tests/tcg: add gdb runner variant, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 07/26] tests/tcg: enable tcg tests for softmmu, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 08/26] tests/tcg: add QEMU_OPT option for test runner, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 05/26] Makefile: explicitly pass $(BUILD_DIR) to gcovr, Alex Bennée, 2019/03/12
- [Qemu-devel] [PULL 04/26] Makefile: explicitly pass $(SRC_PATH) to gcovr, Alex Bennée, 2019/03/12
- Re: [Qemu-devel] [PULL 00/26] final testing updates for 4.0, Philippe Mathieu-Daudé, 2019/03/12
- Re: [Qemu-devel] [PULL 00/26] final testing updates for 4.0, Peter Maydell, 2019/03/14