Re: [Qemu-devel] Maintainers, please tell us how to boot your machines!

[Cédric Le Goater]

On 3/13/19 4:35 AM, David Gibson wrote:
> On Tue, Mar 12, 2019 at 06:36:05PM +0100, Markus Armbruster wrote:
>> Dear board code maintainers,
>>
>> This is a (rather late) follow-up to the last QEMU summit.  Minutes[*]:
>>
>>  * Deprecating unmaintained features (devices, targets, backends) in QEMU
>>
>>    QEMU has a mechanism to deprecate features but there remains a lot of
>>    old unmaintained code.  Refactoring is hindered by untested legacy
>>    code, so there is a desire to deprecate unmaintained features more
>>    often.
>>
>>    [...]
>>
>>    We should require at least a minimal test for each board; if nobody
>>    cares enough to come up with one, that board should be deprecated.
>>
>>    [...]
>>
>>    Also see the qemu-devel discussion about deprecating code:
>>    https://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg05828.html.
>>
>> That's a link to "Minutes of KVM Forum BoF on deprecating stuff".
>> Quote:
>>
>>  * One obvious class of candidates for removal is machines we don't know
>>    how to boot, or can't boot, say because we lack required firmware
>>    and/or OS.
>>
>>    Of course, "can boot" should be an automated test.  As a first step
>>    towards that, we should at least document how to boot each machine.
>>    We're going to ask machine maintainers to do that.
>>
>> Let's get going on this.
>>
>> I gathered the machine types, mapped them to source files, which I fed
>> to get_maintainer.pl.  Results are appended.  If you're cc'ed,
>> MAINTAINERS fingers you for at least one machine type's source file.
>> Please tell us for all of them how to to a "meaningful" boot test.
>>
>> For now, what's "meaningful" is entirely up to you.  Booting Linux
>> certainly is.
>>
>> Make sure to include a complete QEMU command line.  If your QEMU command
>> line requires resources beyond the QEMU source tree and what we build
>> from it, please detail them, and provide download URLs as far as
>> possible.
>>
>> Goals for this exercise:
>>
>> * Gather information we need to cover more machines in our automated
>>   testing.
>>
>>   Related work:
>>   [PATCH v4 00/19] Acceptance Tests: target architecture support
>>   Message-Id: <address@hidden>
>>   https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg03881.html
>>
>> * Maybe identify a few machines we don't know how to boot anymore.
>>
>> Thanks in advance for your help!
>>
>>
>>
>> Machines with at least one maintainer:
> 
> [snip]
>>     = hw/ppc/pnv.c =
>>     David Gibson <address@hidden> (maintainer:PowerPC)
>>     address@hidden (open list:PowerPC)
> 
> Cédric already posted information for these, thanks.
> 
> Cédric, could you also send me a patch to MAINTAINERS to add yourself
> as a maintainer of the powernv machine type (I'm fine remaining
> co-maintainer).

Sure. 

>>     = hw/ppc/prep.c =
>>     "Hervé Poussineau" <address@hidden> (maintainer:PReP)
>>     David Gibson <address@hidden> (maintainer:PowerPC)
>>     address@hidden (open list:PReP)
> 
> I'm hoping Hervé can answer this one.
> 
>>     = hw/ppc/sam460ex.c =
>>     BALATON Zoltan <address@hidden> (maintainer:sam460ex)
>>     David Gibson <address@hidden> (maintainer:PowerPC)
>>     address@hidden (open list:sam460ex)
> 
> I believe Zoltan should be able to answer this one.
> 
>>
>>     = hw/ppc/virtex_ml507.c =
>>     "Edgar E. Iglesias" <address@hidden> (odd fixer:virtex_ml507)
>>     David Gibson <address@hidden> (maintainer:PowerPC)
>>     address@hidden (open list:virtex_ml507)
> 
> I hope Edgar can answer this one, I have no idea.
> 
>>     = hw/ppc/spapr.c =
>>     David Gibson <address@hidden> (supporter:sPAPR)
>>     address@hidden (open list:sPAPR)
> 
> Lots of ways to boot this.  Modern RHEL, CentOS, Fedora, Debian or
> Ubuntu for ppc64 should work.  kvm-unit-tests also supports this
> machine.  Any other details you want?
> 
> This is actively maintained and tested downstream by Red Hat, possibly
> amongst others.
> 
> [snip]
>>     = hw/ppc/e500plat.c =
>>     David Gibson <address@hidden> (odd fixer:e500)
>>     address@hidden (open list:e500)
> 
> I receive and merge occasional fixes for this, but I don't really know
> how to use it.  Alex Graf or Greg Kurz might know a bit more.
> 
>>     = hw/ppc/mac_newworld.c =
>>     Mark Cave-Ayland <address@hidden> (odd fixer:New World (mac99))
>>     David Gibson <address@hidden> (reviewer:New World (mac99))
>>     address@hidden (open list:New World (mac99))
>>
>>     = hw/ppc/mac_oldworld.c =
>>     Mark Cave-Ayland <address@hidden> (odd fixer:Old World (g3beige))
>>     David Gibson <address@hidden> (reviewer:Old World (g3beige))
>>     address@hidden (open list:Old World (g3beige))
> 
> Mark, can you answer these ones.
> 
>>
>>     = hw/ppc/mpc8544ds.c =
>>     David Gibson <address@hidden> (odd fixer:mpc8544ds)
>>     address@hidden (open list:mpc8544ds)
>>
>>     = hw/ppc/ppc405_boards.c =
>>     David Gibson <address@hidden> (odd fixer:ppc4xx)
>>     address@hidden (open list:ppc4xx)
>>
>>     = hw/ppc/ppc440_bamboo.c =
>>     David Gibson <address@hidden> (odd fixer:ppc4xx)
>>     address@hidden (open list:ppc4xx)
> 
> I don't know much about these, though I receive and apply patches
> occasionally, so presumably they work for someone.  Alex Graf might
> know more.
> 

We should probably also update :

        https://wiki.qemu.org/Documentation/Platforms/PowerPC

I don't think we have a page for PPC64. Do we ? 

Thanks,
 
C.