Re: [Qemu-devel] [PULL 22/27] vl: Create block backends before setting machine properties

[Markus Armbruster]

Kevin Wolf <address@hidden> writes:

> Am 11.03.2019 um 23:08 hat Markus Armbruster geschrieben:
>> qemu-system-FOO's main() acts on command line arguments in its own
>> idiosyncratic order.  There's not much method to its madness.
>> Whenever we find a case where one kind of command line argument needs
>> to refer to something created for another kind later, we rejigger the
>> order.
>> 
>> Block devices get created long after machine properties get processed.
>> Therefore, block device machine properties can be created, but not
>> set.  No such properties exist.  But the next commit will create some.
>> Time to rejigger again: create block devices earlier.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>> Message-Id: <address@hidden>
>> Reviewed-by: Michael S. Tsirkin <address@hidden>
>
> This commit broke qemu-iotests 055. Looks like migration_object_init()
> must come before configure_blockdev().

One of the slow tests not covered by make check-block...

I posted a proposed fix.  Thanks!