[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 4/5] Acceptance tests: depend on qemu-img
From: |
Cleber Rosa |
Subject: |
[Qemu-devel] [PATCH v5 4/5] Acceptance tests: depend on qemu-img |
Date: |
Wed, 13 Mar 2019 16:46:10 -0400 |
Tests using the avocado.utils.vmimage library make use of qemu-img,
and because it makes sense to use the version matching the rest of the
source code, let's make sure it gets built.
Its selection, instead of a possible qemu-img binary installed system
wide, is already dealt with by the change that adds the build dir to
the PATH during the test execution.
This is based on the same work for qemu-iotests, and suggested by its
author:
- https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00951.html
CC: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
tests/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 546c101a14..77d71086f3 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -1159,7 +1159,7 @@ $(TESTS_RESULTS_DIR):
check-venv: $(TESTS_VENV_DIR)
-check-acceptance: check-venv $(TESTS_RESULTS_DIR)
+check-acceptance: check-venv $(TESTS_RESULTS_DIR) qemu-img$(EXESUF)
$(call quiet-command, \
$(TESTS_VENV_DIR)/bin/python -m avocado \
--show=$(AVOCADO_SHOW) run --job-results-dir=$(TESTS_RESULTS_DIR) \
--
2.20.1
- [Qemu-devel] [PATCH v5 0/5] Add "boot_linux" acceptance test, Cleber Rosa, 2019/03/13
- [Qemu-devel] [PATCH v5 2/5] Acceptance tests: keep a stable reference to the QEMU build dir, Cleber Rosa, 2019/03/13
- [Qemu-devel] [PATCH v5 1/5] Acceptance tests: use relative location for tests, Cleber Rosa, 2019/03/13
- [Qemu-devel] [PATCH v5 3/5] Acceptance tests: add the build directory to the system PATH, Cleber Rosa, 2019/03/13
- [Qemu-devel] [PATCH v5 4/5] Acceptance tests: depend on qemu-img,
Cleber Rosa <=
- [Qemu-devel] [PATCH v5 5/5] Add "boot_linux" acceptance test for x86_64 and pc machine type, Cleber Rosa, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 0/5] Add "boot_linux" acceptance test, no-reply, 2019/03/13
- Re: [Qemu-devel] [PATCH v5 0/5] Add "boot_linux" acceptance test, Wainer dos Santos Moschetta, 2019/03/14