[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: remove slirp submodule support that
From: |
Stefano Garzarella |
Subject: |
Re: [Qemu-devel] [PATCH] configure: remove slirp submodule support that doesn't exist yet |
Date: |
Thu, 14 Mar 2019 10:38:53 +0100 |
User-agent: |
NeoMutt/20180716 |
On Wed, Mar 13, 2019 at 05:31:57PM +0000, Daniel P. Berrangé wrote:
> The slirp code is not yet split off into a separate repository, so
> configuring QEMU to use slirp as a submodule is premature. This
> causes the non-existant "slirp" to be requested from git when syncing
> submodules. This in turn appears to be cause of non-deterministic
> failures some developers are seeing with QEMU's submodule sync process.
>
Fixes: 675b9b53687 "build-sys: link with slirp as an external project"
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
>
> NB, this change should be reverted only once slirp exists in
> the .git-modules file.
>
> configure | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
Reviewed-by: Stefano Garzarella <address@hidden>