qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 0/8] slirp: clarify license of slirp as BSD-3


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v3 0/8] slirp: clarify license of slirp as BSD-3
Date: Thu, 14 Mar 2019 08:44:06 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1

On 3/14/19 8:19 AM, Samuel Thibault wrote:
> Hello,
> 
> Should this go through my tree, or perhaps it can be directly pushed to
> master by Peter since it's no-code-only-copyright changes?

I think this definitely qualifies as 4.0 material.

However, while it does not affect compilation, it DOES have legal
ramification; I'd feel a lot better about having R-b on every patch,
that we had a second (or third) set of eyes double-check that the right
SPDX identifier is used everywhere.  I don't have time to complete that
audit today, so I'm hoping someone else will step in and help.  (This is
complicated by the fact that the email alone does not show the existing
license; it may be easier to apply the patch locally, and then use git
diff tuned to give a 20 or 30 line context instead of the usual default
of 3, to make it easier to check for SPDX match to existing licenses on
each file being modified)

And thanks, Marc-André, for bearing with my nit-pickiness on this
series. I hope you agree with my insistence that we get this right, so
that we don't expose ourselves to legal troubles down the road. I like
the split in this series, even if I have not had time to finish an audit
that the changes in 3-6 are correct.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]