Re: [Qemu-devel] [PATCH v8 3/6] ui: add keycodemapdb repository as a GIT submodule

[Peter Maydell]

On Fri, 29 Sep 2017 at 11:12, Daniel P. Berrange <address@hidden> wrote:
>
> The https://gitlab.com/keycodemap/keycodemapdb/ repo contains a
> data file mapping between all the different scancode/keycode/keysym
> sets that are known, and a tool to auto-generate lookup tables for
> different combinations

Hi Dan; apologies for hauling up this commit from 2017, but
I just noticed something while reading through configure:

> diff --git a/configure b/configure
> index b324e057f1..eb420abc47 100755
> --- a/configure
> +++ b/configure
> @@ -264,7 +264,13 @@ cc_i386=i386-pc-linux-gnu-gcc
>  libs_qga=""
>  debug_info="yes"
>  stack_protector=""
> -git_submodules=""
> +
> +if test -e "$source_path/.git"
> +then
> +    git_submodules="ui/keycodemapdb"
> +else
> +    git_submodules=""
> +fi

Configure has a --source-path option, which overrides the
default $source_path setting (of the directory where the
configure script lives), but this commit (927128222b0a91f56c13a)
added a use of $source_path before the part of configure that
parses the option and updates $source_path accordingly.
Could this lump of code (and the later enhancements to it) be moved
further down in the file?

(Alternatively, we could drop the --source-path option entirely:
I didn't even know it existed and I'm not sure it's very
useful...)

thanks
-- PMM