Re: [Qemu-devel] [PATCH] scripts/make-release: Stop shipping u-boot source as a tarball

[Michael Roth]

Quoting Peter Maydell (2019-03-14 10:56:28)
> In commit d0dead3b6df7f6cd970e we changed to shipping the u-boot
> sources as a tarball, to work around a problem where they
> contained a file and directory that had the same name except
> for case, which was preventing QEMU's source tarball being
> unpacked on case-insensitive filesystems.
> 
> In commit f2a3b549e357041f86d7e we updated our u-boot blob
> and sources to v2019.01, which no longer has this problem,
> so we can finally remove our workaround (effectively
> reverting d0dead3b6df7f6cd970e).
> 
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Michael Roth <address@hidden>

> ---
> Tested (with a slightly hand-hacked script) by creating a tarball
> with master as of dbbc277510aa39ea and unpacking it on OSX.
> ---
>  scripts/make-release | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/scripts/make-release b/scripts/make-release
> index c14f75b12c8..b4af9c9e520 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -20,10 +20,6 @@ git checkout "v${version}"
>  git submodule update --init
>  (cd roms/seabios && git describe --tags --long --dirty > .version)
>  (cd roms/skiboot && ./make_version.sh > .version)
> -# FIXME: The following line is a workaround for avoiding filename collisions
> -# when unpacking u-boot sources on case-insensitive filesystems. Once we
> -# update to something with u-boot commit 610eec7f0 we can drop this line.
> -tar --exclude=.git -cjf roms/u-boot.tar.bz2 -C roms u-boot && rm -rf 
> roms/u-boot
>  popd
>  tar --exclude=.git -cjf ${destination}.tar.bz2 ${destination}
>  rm -rf ${destination}
> -- 
> 2.20.1
>