[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/8] hw/acpi: Simplify the Makefile logic
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 3/8] hw/acpi: Simplify the Makefile logic |
Date: |
Sun, 17 Mar 2019 01:54:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 |
On 3/17/19 1:22 AM, Philippe Mathieu-Daudé wrote:
> Now that we use Kconfig, we can simplify this Makefile.
>
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/acpi/Makefile.objs | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/hw/acpi/Makefile.objs b/hw/acpi/Makefile.objs
> index 2d46e3789a..c86edfbed9 100644
> --- a/hw/acpi/Makefile.objs
> +++ b/hw/acpi/Makefile.objs
> @@ -1,4 +1,3 @@
> -ifeq ($(CONFIG_ACPI),y)
> common-obj-$(CONFIG_ACPI_X86) += core.o piix4.o pcihp.o
> common-obj-$(CONFIG_ACPI_X86_ICH) += ich9.o tco.o
> common-obj-$(CONFIG_ACPI_CPU_HOTPLUG) += cpu_hotplug.o
> @@ -6,16 +5,11 @@ common-obj-$(CONFIG_ACPI_MEMORY_HOTPLUG) += memory_hotplug.o
> common-obj-$(CONFIG_ACPI_CPU_HOTPLUG) += cpu.o
> common-obj-$(CONFIG_ACPI_NVDIMM) += nvdimm.o
> common-obj-$(CONFIG_ACPI_VMGENID) += vmgenid.o
> -common-obj-$(call lnot,$(CONFIG_ACPI_X86)) += acpi-stub.o
> -
> common-obj-y += acpi_interface.o
> common-obj-y += bios-linker-loader.o
> common-obj-y += aml-build.o
> common-obj-$(CONFIG_TPM) += tpm.o
> -
> common-obj-$(CONFIG_IPMI) += ipmi.o
> +
> common-obj-$(call lnot,$(CONFIG_IPMI)) += ipmi-stub.o
> -else
> -common-obj-y += acpi-stub.o
> -endif
> -common-obj-$(CONFIG_ALL) += acpi-stub.o ipmi-stub.o
> +common-obj-$(call lnot,$(CONFIG_ACPI)) += acpi-stub.o
MinGW unhappy here :(
make[1]: *** No rule to make target '../hw/acpi/ipmi-stub.o', needed by
'qemu-system-aarch64w.exe'. Stop.
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:449: subdir-aarch64-softmmu] Error 2
make: *** Waiting for unfinished jobs....
GEN x86_64-softmmu/qemu-system-x86_64.exe
https://patchew.org/logs/address@hidden/address@hidden/?type=message
- [Qemu-devel] [PATCH 0/8] hw/isa: Complete the VT82C686B southbridge Kconfig, Philippe Mathieu-Daudé, 2019/03/16
- [Qemu-devel] [PATCH 1/8] hw/input/Kconfig: Rename the 8042 PS/2 Keyboard Controller, Philippe Mathieu-Daudé, 2019/03/16
- [Qemu-devel] [PATCH 2/8] hw/i2c/Kconfig: Add an entry for the SMBus, Philippe Mathieu-Daudé, 2019/03/16
- [Qemu-devel] [PATCH 3/8] hw/acpi: Simplify the Makefile logic, Philippe Mathieu-Daudé, 2019/03/16
- Re: [Qemu-devel] [PATCH 3/8] hw/acpi: Simplify the Makefile logic,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH 4/8] hw/isa/southbridge: Rename ACPI_X86_ICH to ACPI_ICH9, Philippe Mathieu-Daudé, 2019/03/16
- [Qemu-devel] [PATCH 5/8] hw/acpi/Kconfig: Remove ICH9 dependency on X86, Philippe Mathieu-Daudé, 2019/03/16
- [Qemu-devel] [PATCH 6/8] hw/acpi/Kconfig: Introduce the ACPI_PIIX4 config, Philippe Mathieu-Daudé, 2019/03/16
[Qemu-devel] [PATCH 7/8] hw/acpi/Kconfig: Add the ACPI_SMBUS depency to ACPI_PIIX4, Philippe Mathieu-Daudé, 2019/03/16