[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL for-4.0 0/7] qemu-ga patch queue for 4.0
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PULL for-4.0 0/7] qemu-ga patch queue for 4.0 |
Date: |
Mon, 18 Mar 2019 09:33:44 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PULL for-4.0 0/7] qemu-ga patch queue for 4.0
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
6049403cd7 qmp: common 'id' handling & make QGA conform to QMP spec
7617b6d75f qga: process_event() simplification
780b66b189 qga: Fix guest-get-fsinfo PCI address collection in Windows
398c80ae8e qga-win: fix VSS build breakage due to unintended gnu99 C++ flag
232ff93fdd qga-win: include glib when building VSS DLL
5631cb464b qga-win: Adding support for Windows Server 2019 get-osinfo command
626bf490e5 qga: update docs with systemd suspend support info
=== OUTPUT BEGIN ===
1/7 Checking commit 626bf490e544 (qga: update docs with systemd suspend support
info)
2/7 Checking commit 5631cb464b54 (qga-win: Adding support for Windows Server
2019 get-osinfo command)
3/7 Checking commit 232ff93fddbb (qga-win: include glib when building VSS DLL)
4/7 Checking commit 398c80ae8e02 (qga-win: fix VSS build breakage due to
unintended gnu99 C++ flag)
5/7 Checking commit 780b66b18953 (qga: Fix guest-get-fsinfo PCI address
collection in Windows)
ERROR: spaces required around that '&' (ctx:VxV)
#312: FILE: qga/commands-win32.c:668:
+ &type, (PBYTE)&bus, size, NULL)) {
^
ERROR: spaces required around that '&' (ctx:VxV)
#336: FILE: qga/commands-win32.c:680:
+ &type, (PBYTE)&addr, size, NULL)) {
^
ERROR: spaces required around that '&' (ctx:VxV)
#348: FILE: qga/commands-win32.c:692:
+ &type, (PBYTE)&ui_slot, size, NULL)) {
^
total: 3 errors, 0 warnings, 419 lines checked
Patch 5/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/7 Checking commit 7617b6d75fd5 (qga: process_event() simplification)
7/7 Checking commit 6049403cd793 (qmp: common 'id' handling & make QGA conform
to QMP spec)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PULL for-4.0 0/7] qemu-ga patch queue for 4.0, Michael Roth, 2019/03/18
- [Qemu-devel] [PULL for-4.0 2/7] qga-win: Adding support for Windows Server 2019 get-osinfo command, Michael Roth, 2019/03/18
- [Qemu-devel] [PULL for-4.0 4/7] qga-win: fix VSS build breakage due to unintended gnu99 C++ flag, Michael Roth, 2019/03/18
- [Qemu-devel] [PULL for-4.0 3/7] qga-win: include glib when building VSS DLL, Michael Roth, 2019/03/18
- [Qemu-devel] [PULL for-4.0 6/7] qga: process_event() simplification, Michael Roth, 2019/03/18
- [Qemu-devel] [PULL for-4.0 7/7] qmp: common 'id' handling & make QGA conform to QMP spec, Michael Roth, 2019/03/18
- [Qemu-devel] [PULL for-4.0 1/7] qga: update docs with systemd suspend support info, Michael Roth, 2019/03/18
- [Qemu-devel] [PULL for-4.0 5/7] qga: Fix guest-get-fsinfo PCI address collection in Windows, Michael Roth, 2019/03/18
- Re: [Qemu-devel] [PULL for-4.0 0/7] qemu-ga patch queue for 4.0,
no-reply <=
- Re: [Qemu-devel] [PULL for-4.0 0/7] qemu-ga patch queue for 4.0, Peter Maydell, 2019/03/19