[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] blockjob: fix user pause in block_job_error_act
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH] blockjob: fix user pause in block_job_error_action |
|
Date: |
Tue, 19 Mar 2019 12:31:56 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 3/19/19 5:24 AM, Vladimir Sementsov-Ogievskiy wrote:
> Job (especially mirror) may call block_job_error_action several
> times before actual pause if it has several in-flight requests.
>
> block_job_error_action will call job_pause more than once in this case,
> which lead to following block-job-resume qmp command can't actually
> resume the job.
>
> Fix it by do not increase pause level in block_job_error_action if
> user_paused already set.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
Not that you need it now, but:
Reviewed-by: John Snow <address@hidden>
Good find.
--js