Re: [Qemu-devel] [PULL 00/12] EDK2 Firmware roms

[Laszlo Ersek]

Hi Peter,

On 03/19/19 10:22, Peter Maydell wrote:
> On Mon, 18 Mar 2019 at 21:21, Philippe Mathieu-Daudé <address@hidden>
> wrote:
>>
>> Hi Peter,
>>
>> Le dim. 17 mars 2019 23:02, Peter Maydell <address@hidden>
>> a écrit :
>>>
>>> On Sun, 17 Mar 2019 at 20:29, Peter Maydell
>>> <address@hidden> wrote:
>>>> Hi; this fails to build on OSX and OpenBSD:
>>>>
>>>>   UNXZ    pc-bios/edk2-aarch64-code.fd.xz
>>>> /bin/sh: xz: command not found
>>
>>
>> I checked Travis builds for OSX. I suppose the Travis image has xz
>> pulled/pre-installed and yours doesn't.
>
> Yeah, I expect I could install xz from homebrew here.
>
>> I used to check on OpenBSD until realizing you are the only one doing
>> that. After having spent quite some time on it I removed it from my
>> list, thus missed this failure. EDK2 doesn't build on OpenBSD but
>> still this OS should be able to decompress the ROMs.
>
> At the moment I compile test it but don't 'make check' it
> (ie I just use the tests/vm/openbsd setup).
>
> We could probably not unreasonably add 'xz' to the
> build dependencies,

I don't know how to do that, sorry. Are they tracked in some text file
perhaps? (I.e. for a human reader?)

> but we'd need to add it to the OpenBSD image in tests/vm.

Phil vaguely directed me (without access to a real computer) to some
patches he had sent previously, and I found:

  [Qemu-devel] [PATCH v2 11/18] tests/vm/openbsd: Install GNU sed from the ports
  msgid <address@hidden>

This patch proposed to add some "pkg_add" commands to
"tests/vm/openbsd".

However, the patch didn't get any feedback (specific feedback, that is;
no message was sent directly in response). And Phil dropped it from the
v3 posting:

  [Qemu-devel] [PATCH v3 0/8] OpenBSD: Block layer fixes (was 'Enable qtesting')
  msgid <address@hidden>

Ultimately I don't know how to satisfy this requirement either -- let
alone the OSX requirement, for which I can't even find a file under
"tests/vm".

So, I guess this PULL will indeed miss 4.0.

I'll ask Phil to handle the "xz" dependencies (he apparently knows how
to do that) and also to resubmit the PULL, once 4.0 is out and Phil
regains access to a real computer.

(BTW, thank you very much for the PULL, Phil.)

Thanks
Laszlo