[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH] scripts/decodetree.py: Fix variable-length
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH] scripts/decodetree.py: Fix variable-length ISA |
|
Date: |
Wed, 20 Mar 2019 18:43:37 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 3/20/19 7:27 AM, Yoshinori Sato wrote:
> Hi.
> I found some problem in tested RX instructions.
> It is usable in RX instructions, but I think that there
> is a better fix because I am not familiar with Python.
The patch itself look ok, but needs some changes.
> I fixed three point.
> - Added ctx to !function args.
This seems fine. But it needs either
(1) A command-line option, or
(2) Changes to all existing users in the tree.
Otherwise the build breaks for the other targets.
> - Fixed group operaiton. varinsns required width field.
> - Fixed symbol in decode_load_bytes args.
Thanks. I can fold these fixes into v2 of the varinsns patches.
r~