qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 1/8] slirp: update COPYRIGHT to use full 3-Cl


From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH v3 1/8] slirp: update COPYRIGHT to use full 3-Clause BSD License
Date: Thu, 21 Mar 2019 09:49:35 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0

On 14/03/2019 14.34, Eric Blake wrote:
> On 3/14/19 8:10 AM, Marc-André Lureau wrote:
>> According to commit 2f5f89963186d42a7ded253bc6cf5b32abb45cec ("Remove
>> the advertising clause from the slirp license"), Danny Gasparovski
>> gave permission to license slirp code under 3-clause BSD license:
>>
>>     Subject: RE: Slirp license
>>     Date: Thu, 8 Jan 2009 10:51:00 +1100
>>     From: "Gasparovski, Daniel" <address@hidden>
>>     To: "Richard Fontana" <address@hidden>
>>
>>     I have no objection to having Slirp code in QEMU be licensed under
>>     the 3-clause BSD license.
>>
>> slirp/COPYRIGHT's initial version in 2004 (commit 5fafdf24) listed
>> only 3 clauses BUT used the poisonous advertising clause for clause 3
>> which is the controversial clause of non-free 4-clause (that is, it
>> appears that the BSD-4 license was copied, and then the WRONG clause
>> was deleted, when creating COPYRIGHT.

When you look at the files in the original slirp repository with:

 cvs -z3 -d:pserver:address@hidden:/cvsroot/slirp co -P
slirp-1.0

... you can see that the file already looked like this there. So I guess
the statement from Danny Gasparovski was rather about the copyright
remarks in the source files. But for consistency with the source files,
the missing clause should be added to this COPYRIGHT file here, too, so
I think the patch is the right thing to do, thus:

Reviewed-by: Thomas Huth <address@hidden>

>> + 3. Neither the name of the copyright holder nor the names of its
>> +    contributors may be used to endorse or promote products derived
>> +    from this software without specific prior written permission.
> 
> Matches the text on both:
> https://spdx.org/licenses/BSD-3-Clause.html
> https://opensource.org/licenses/BSD-3-Clause
> 
> (well, those two pages differ on whether "All rights reserved" is part
> of the boilerplate, but that's a different battle that doesn't affect
> this cleanup)

"All rights reserved" is not needed anymore since the year 2000, see:

https://en.wikipedia.org/wiki/All_rights_reserved#Obsolescence

 Thomas


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]