[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/2] implement the failover feature for assi
|
From: |
no-reply |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH 0/2] implement the failover feature for assigned network devices |
|
Date: |
Fri, 22 Mar 2019 06:54:43 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [RFC PATCH 0/2] implement the failover feature for
assigned network devices
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
4aa7f06 net/virtio: add failover support
5d2911f qdev/qbus: Add hidden device support
=== OUTPUT BEGIN ===
1/2 Checking commit 5d2911f6d6d4 (qdev/qbus: Add hidden device support)
ERROR: trailing whitespace
#22: FILE: hw/core/qdev.c:218:
+ $
ERROR: that open brace { should be on the previous line
#30: FILE: hw/core/qdev.c:226:
+ if (match_found)
+ {
ERROR: that open brace { should be on the previous line
#36: FILE: hw/core/qdev.c:232:
+ if (!match_found)
+ {
WARNING: Block comments use a leading /* on a separate line
#89: FILE: include/hw/qdev-core.h:161:
+ /* This callback is called just upon init of the DeviceState
ERROR: line over 90 characters
#93: FILE: include/hw/qdev-core.h:165:
+ void (*should_be_hidden)(DeviceListener *listener, QemuOpts
*device_opts,bool *match_found, bool *res);
ERROR: space required after that ',' (ctx:VxV)
#93: FILE: include/hw/qdev-core.h:165:
+ void (*should_be_hidden)(DeviceListener *listener, QemuOpts
*device_opts,bool *match_found, bool *res);
^
ERROR: that open brace { should be on the previous line
#123: FILE: qdev-monitor.c:576:
+ if (strcmp(name, "standby") == 0)
+ {
ERROR: that open brace { should be on the previous line
#126: FILE: qdev-monitor.c:579:
+ if (qdev_should_hide_device(opts, errp) && errp && !*errp)
+ {
ERROR: that open brace { should be on the previous line
#130: FILE: qdev-monitor.c:583:
+ else if (errp && *errp)
+ {
ERROR: else should follow close brace '}'
#130: FILE: qdev-monitor.c:583:
+ }
+ else if (errp && *errp)
ERROR: that open brace { should be on the previous line
#140: FILE: qdev-monitor.c:593:
+ if (qemu_opt_foreach(opts, has_standby_device, opts, err) == 0)
+ {
ERROR: trailing whitespace
#155: FILE: qdev-monitor.c:607:
+ $
ERROR: that open brace { should be on the previous line
#156: FILE: qdev-monitor.c:608:
+ if (opts && should_hide_device(opts, &err))
+ {
ERROR: that open brace { should be on the previous line
#158: FILE: qdev-monitor.c:610:
+ if(err)
+ {
ERROR: space required before the open parenthesis '('
#158: FILE: qdev-monitor.c:610:
+ if(err)
ERROR: that open brace { should be on the previous line
#173: FILE: qdev-monitor.c:688:
+ if (dev)
+ {
ERROR: that open brace { should be on the previous line
#202: FILE: vl.c:2343:
+ } else if (dev)
+ {
total: 16 errors, 1 warnings, 165 lines checked
Patch 1/2 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/2 Checking commit 4aa7f06bed23 (net/virtio: add failover support)
ERROR: that open brace { should be on the previous line
#73: FILE: hw/net/virtio-net.c:2650:
+ if (!n->primary_dev && err)
+ {
WARNING: line over 80 characters
#82: FILE: hw/net/virtio-net.c:2659:
+static void virtio_net_handle_migration_primary(VirtIONet *n, MigrationState *
s)
WARNING: Block comments use a leading /* on a separate line
#88: FILE: hw/net/virtio-net.c:2665:
+ /* Request unplug
WARNING: Block comments should align the * on each line
#91: FILE: hw/net/virtio-net.c:2668:
+ *
+ */
ERROR: that open brace { should be on the previous line
#93: FILE: hw/net/virtio-net.c:2670:
+ if (!err)
+ {
ERROR: that open brace { should be on the previous line
#99: FILE: hw/net/virtio-net.c:2676:
+ if (should_be_hidden && !n->primary_dev)
+ {
ERROR: that open brace { should be on the previous line
#104: FILE: hw/net/virtio-net.c:2681:
+ else
+ {
ERROR: else should follow close brace '}'
#104: FILE: hw/net/virtio-net.c:2681:
+ }
+ else
ERROR: space required after that ',' (ctx:VxV)
#114: FILE: hw/net/virtio-net.c:2691:
+ virtio_net_handle_migration_primary(n,s);
^
ERROR: line over 90 characters
#117: FILE: hw/net/virtio-net.c:2694:
+static void virtio_net_primary_should_be_hidden(DeviceListener *listener,
QemuOpts *device_opts,
ERROR: "foo * bar" should be "foo *bar"
#121: FILE: hw/net/virtio-net.c:2698:
+ const char * dev_id = qemu_opts_id(device_opts);
ERROR: space required after that ',' (ctx:WxV)
#123: FILE: hw/net/virtio-net.c:2700:
+ *match_found = !strcmp(n->net_conf.primary_id_str ,dev_id);
^
ERROR: line over 90 characters
#124: FILE: hw/net/virtio-net.c:2701:
+ if (atomic_read(&n->primary_should_be_hidden) &&
!strcmp(qemu_opt_get(device_opts, "driver"), "vfio-pci")
WARNING: line over 80 characters
#143: FILE: hw/net/virtio-net.c:2743:
+ n->primary_listener.should_be_hidden =
virtio_net_primary_should_be_hidden;
ERROR: Missing Signed-off-by: line(s)
total: 11 errors, 4 warnings, 162 lines checked
Patch 2/2 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden