Re: [Qemu-devel] [PATCH V2 2/4] tests/libqos: fix usage of bool in pci-pc.c

[Eric Blake]

On 3/23/19 9:26 AM, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from 
> stdbool.h.
> 
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also 
> use
> TRUE and FALSE for variables that are declared as "bool" (the type from 
> <stdbool.h>).
> 
> Signed-off-by: Jafar Abdi <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
>  tests/libqos/pci-pc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Technically, I only reviewed patch 1 of your v1 series, so adding my R-b
to 2-4 was premature. But now that I've read through all 4 patches of
v2, I'm fine with you keeping it for all of them.

Thanks for resending - it looks a lot better!

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature