[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] qemu-img: Report bdrv_block_status failures
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] qemu-img: Report bdrv_block_status failures |
|
Date: |
Mon, 25 Mar 2019 10:11:38 +0100 |
|
User-agent: |
Mutt/1.11.3 (2019-02-01) |
Am 23.03.2019 um 22:26 hat Eric Blake geschrieben:
> If bdrv_block_status_above() fails, we are aborting the convert
> process but failing to print an error message. Broken in commit
> 690c7301 (v2.4) when rewriting convert's logic.
>
> Discovered when teaching nbdkit to support NBD_CMD_BLOCK_STATUS, and
> accidentally violating the protocol by returning more than one extent
> in spite of qemu asking for NBD_CMD_FLAG_REQ_ONE. The qemu NBD code
> should probably handle the server's non-compliance more gracefully
> than failing with EINVAL, but qemu-img shouldn't be silently
> squelching any block status failures. It doesn't help that qemu 3.1
> masks the qemu-img bug with extra noise that the nbd code is dumping
> to stderr (that noise was cleaned up in d8b4bad8).
>
> Reported-by: Richard W.M. Jones <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>