[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/6] target/arm: Fix non-parallel expansion of CASP
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PULL 1/6] target/arm: Fix non-parallel expansion of CASP |
Date: |
Mon, 25 Mar 2019 14:31:47 +0000 |
From: Richard Henderson <address@hidden>
The second word has been loaded from the unincremented
address since the first commit.
Fixes: 44ac14b06fa
Reported-by: Alex Bennée <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Tested-by: Alex Bennée <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>
---
target/arm/translate-a64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 19590463433..dcdeb80176e 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -2510,7 +2510,7 @@ static void gen_compare_and_swap_pair(DisasContext *s,
int rs, int rt,
tcg_gen_qemu_ld_i64(d1, clean_addr, memidx,
MO_64 | MO_ALIGN_16 | s->be_data);
tcg_gen_addi_i64(a2, clean_addr, 8);
- tcg_gen_qemu_ld_i64(d2, clean_addr, memidx, MO_64 | s->be_data);
+ tcg_gen_qemu_ld_i64(d2, a2, memidx, MO_64 | s->be_data);
/* Compare the two words, also in memory order. */
tcg_gen_setcond_i64(TCG_COND_EQ, c1, d1, s1);
--
2.20.1
- [Qemu-devel] [PULL 0/6] target-arm queue, Peter Maydell, 2019/03/25
- [Qemu-devel] [PULL 1/6] target/arm: Fix non-parallel expansion of CASP,
Peter Maydell <=
- [Qemu-devel] [PULL 2/6] nrf51_gpio: reflect pull-up/pull-down to IRQs, Peter Maydell, 2019/03/25
- [Qemu-devel] [PULL 3/6] target/arm: add PCI_TESTDEV back to default config, Peter Maydell, 2019/03/25
- [Qemu-devel] [PULL 4/6] target/arm: fix crash on pmu register access, Peter Maydell, 2019/03/25
- [Qemu-devel] [PULL 6/6] target/arm: make pmccntr_op_start/finish static, Peter Maydell, 2019/03/25
- [Qemu-devel] [PULL 5/6] target/arm: cortex-a7 and cortex-a15 have pmus, Peter Maydell, 2019/03/25
- Re: [Qemu-devel] [PULL 0/6] target-arm queue, Peter Maydell, 2019/03/25