qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] RFC: build-sys: move slirp as git submodule pro


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] RFC: build-sys: move slirp as git submodule project
Date: Mon, 25 Mar 2019 13:57:53 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0

On 3/25/19 1:50 PM, Eric Blake wrote:
> On 3/25/19 1:04 PM, Marc-André Lureau wrote:
>> The slirp project is now hosted on freedesktop at:
>> https://gitlab.freedesktop.org/slirp.
>>
>> The libslirp source tree there is based on current qemu/slirp filtered
>> through clang-format, and can thus be directly used through a
>> git submodule.
> 
> Indeed, doing 'diff -ur slirp /path/to/libslirp.git' shows a lot of
> formatting differences. Is there an easy command to see that the
> contents of the two are identical modulo the formatting changes?

Or put another way, what is the precise clang-format command to run on
qemu.git/slirp/, prior to doing my 'diff -ur /path/to/qemu.git/slirp
/path/to/libslirp.git'? And that formula should be in the commit message :)

I don't care if you ran clang-format on every commit in the new
repository so that it has a cleaner git history over all commits that
got transferred (in fact, if you did, that's actually cool, as it will
make git history trawling in libslirp nicer), only that the current
state of the git repository and the current state of the new submodule
are easily correlated.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]