Re: [Qemu-devel] [PATCH v2 1/7] target/mips: Fix <ld|st>.<b|h|w|d> MSA instructions for MIPS big endian host

[Mateja Marjanovic]

On 25.3.19. 22:21, Aleksandar Markovic wrote:
> > From: Mateja Marjanovic <address@hidden>
> > Subject: [PATCH v2 1/7] target/mips: Fix <ld|st>.<b|h|w|d> MSA instructions for 
> > MIPS big endian host
> Please split this patch into one for load instructions and another for
> store instructions.
I will do that.
> I don't think the variable "big_endian" is needed, you should better resolve
> all differences wrt endian via "#if defined(HOST_WORDS_BIGENDIAN)",
> like you did in other patches. It is important to be consistent.

I think you can't have a preprocessing statement inside a macro,
so I did the thing that seemed most similar to that.

> Thanks,
> Aleksandar
Regards,
Mateja