[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/7] block: Remove error messages in bdrv_make_zero()
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 2/7] block: Remove error messages in bdrv_make_zero() |
Date: |
Tue, 26 Mar 2019 16:51:52 +0100 |
There is only a single caller of bdrv_make_zero(), which is qemu-img
convert. If the function fails, we just fall back to a different method
of zeroing out blocks on the target image. There is no good reason to
print error messages on stderr when the higher level operation will
actually succeed.
Signed-off-by: Kevin Wolf <address@hidden>
Acked-by: Eric Blake <address@hidden>
---
block/io.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/block/io.c b/block/io.c
index 2ba603c7bc..952372c2bb 100644
--- a/block/io.c
+++ b/block/io.c
@@ -909,8 +909,6 @@ int bdrv_make_zero(BdrvChild *child, BdrvRequestFlags flags)
}
ret = bdrv_block_status(bs, offset, bytes, &bytes, NULL, NULL);
if (ret < 0) {
- error_report("error getting block status at offset %" PRId64 ":
%s",
- offset, strerror(-ret));
return ret;
}
if (ret & BDRV_BLOCK_ZERO) {
@@ -919,8 +917,6 @@ int bdrv_make_zero(BdrvChild *child, BdrvRequestFlags flags)
}
ret = bdrv_pwrite_zeroes(child, offset, bytes, flags);
if (ret < 0) {
- error_report("error writing zeroes at offset %" PRId64 ": %s",
- offset, strerror(-ret));
return ret;
}
offset += bytes;
--
2.20.1
- [Qemu-devel] [PULL 0/7] Block layer patches, Kevin Wolf, 2019/03/26
- [Qemu-devel] [PULL 1/7] iotests: add 248: test resume mirror after auto pause on ENOSPC, Kevin Wolf, 2019/03/26
- [Qemu-devel] [PULL 2/7] block: Remove error messages in bdrv_make_zero(),
Kevin Wolf <=
- [Qemu-devel] [PULL 3/7] block: Add BDRV_REQ_NO_FALLBACK, Kevin Wolf, 2019/03/26
- [Qemu-devel] [PULL 4/7] block: Advertise BDRV_REQ_NO_FALLBACK in filter drivers, Kevin Wolf, 2019/03/26
- [Qemu-devel] [PULL 5/7] file-posix: Support BDRV_REQ_NO_FALLBACK for zero writes, Kevin Wolf, 2019/03/26
- [Qemu-devel] [PULL 6/7] qemu-img: Use BDRV_REQ_NO_FALLBACK for pre-zeroing, Kevin Wolf, 2019/03/26
- [Qemu-devel] [PULL 7/7] qemu-io: Add write -n for BDRV_REQ_NO_FALLBACK, Kevin Wolf, 2019/03/26
- Re: [Qemu-devel] [PULL 0/7] Block layer patches, Peter Maydell, 2019/03/26