Re: [Qemu-devel] [PATCH v2 0/4] pvrdma: Add support for SRQ

[Yuval Shaia]

On Tue, Mar 26, 2019 at 02:54:29PM +0200, Kamal Heib wrote:
> This series implements the SRQ (Shared Receive Queue) for the pvrdma
> device, It also includes all the needed functions and definitions for
> support SRQ in the backend and resource management layers.
> 
> Changes from v1->v2:
> - Handle checkpatch.pl warnings. 

Hi Kamal,
I'm done with the review, please check my comments.

Thanks for doing it, this is an advance feature that i wanted to do for
long time.

> 
> Kamal Heib (4):
>   hw/rdma: Add SRQ support to backend layer
>   hw/rdma: Add support for managing SRQ resource
>   hw/rdma: Modify create/destroy QP to support SRQ
>   hw/pvrdma: Add support for SRQ
> 
>  hw/rdma/rdma_backend.c      | 125 +++++++++++++++++++++-
>  hw/rdma/rdma_backend.h      |  18 +++-
>  hw/rdma/rdma_backend_defs.h |   5 +
>  hw/rdma/rdma_rm.c           | 106 +++++++++++++++++-
>  hw/rdma/rdma_rm.h           |  13 ++-
>  hw/rdma/rdma_rm_defs.h      |   9 ++
>  hw/rdma/vmw/pvrdma_cmd.c    | 208 ++++++++++++++++++++++++++++++++----
>  hw/rdma/vmw/pvrdma_main.c   |  16 +++
>  hw/rdma/vmw/pvrdma_qp_ops.c |  46 +++++++-
>  hw/rdma/vmw/pvrdma_qp_ops.h |   1 +
>  10 files changed, 513 insertions(+), 34 deletions(-)
> 
> -- 
> 2.20.1
> 
>