Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 4/6] Categorize devices: i82374

[Philippe Mathieu-Daudé]

Le jeu. 28 mars 2019 08:10, Thomas Huth <address@hidden> a écrit :

> On 27/03/2019 14.34, Ernest Esene wrote:
> > Set category and describe the i82374 device
> >
> > Signed-off-by: Ernest Esene <address@hidden>
> >
> > ---
> > v2:
> >   * split into separate patches
> > ---
> >  hw/dma/i82374.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/dma/i82374.c b/hw/dma/i82374.c
> > index 892f655a7e..5b42dd1bd4 100644
> > --- a/hw/dma/i82374.c
> > +++ b/hw/dma/i82374.c
> > @@ -147,6 +147,8 @@ static void i82374_class_init(ObjectClass *klass,
> void *data)
> >      dc->realize = i82374_realize;
> >      dc->vmsd = &vmstate_i82374;
> >      dc->props = i82374_properties;
> > +    dc->desc = "Intel Enhanced DMA controller";
> > +    set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
> >  }
>
> Not sure if CATEGORY_BRIDGE is really the right thing for a dma
> controller ... maybe better put it into CATEGORY_MISC ?
>

This chipset works in tandem with the i82375 which is a southbridge (PCI to
ISA) so if we try here to model both, this category might seem correct.
This model only handles the DMAC, since historically the others devices
were created in the board. I've a series cleaning that I'll post during
next dev cycle. Maybe this patch can wait for it?


>  Thomas
>
>
> PS: By the way, does somebody know whether this device should be
> user_creatable at all? ... what is the use-case for exposing a DMA
> controller to the user?
>

While the i82375 is, the i82374 is not. The correct patch for next release
might be to remove user_creatable.

>