qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 0/2] spapr-rtas: add ibm, get-vpd RTAS interf


From: Greg Kurz
Subject: Re: [Qemu-devel] [PATCH v7 0/2] spapr-rtas: add ibm, get-vpd RTAS interface
Date: Thu, 28 Mar 2019 14:21:51 +0100

On Wed, 27 Mar 2019 17:41:00 -0300
"Maxiwell S. Garcia" <address@hidden> wrote:

> Here are two patches to add a handler for ibm,get-vpd RTAS calls.
> This RTAS exposes host information in case of set QEMU options
> 'host-serial' and 'host-model' as 'passthrough'.
> 
> The patch 1 creates helper functions to get valid 'host-serial'
> and 'host-model' parameters, guided by QEMU command line. These
> parameters are useful to build the guest device tree and to return
> get-vpd RTAS calls. The patch 2 adds the ibm,get-vpd itself.
> 
> Update v7:
> * rtas_get_vpd_fields as a static array in spapr machine state
> 
> Maxiwell S. Garcia (2):
>   spapr: helper functions to get valid host fields
>   spapr-rtas: add ibm,get-vpd RTAS interface
> 
>  hw/ppc/spapr.c         | 48 +++++++++++----------
>  hw/ppc/spapr_rtas.c    | 96 ++++++++++++++++++++++++++++++++++++++++++
>  include/hw/ppc/spapr.h | 14 +++++-
>  3 files changed, 135 insertions(+), 23 deletions(-)
> 

Hi Maxiwell,

David sent a patch to rework how the host data is exposed to the guest.
Especially, the special casing of the "none" and "passthrough" strings
is no more... I'm afraid you'll have to rework your patches accordingly:
code+changelog in patch 1 and at least changelog in patch 2.

Cheers,

--
Greg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]