Re: [Qemu-devel] [PATCH v2 1/3] iotests: Add 241 to test NBD on unaligned images

[Kevin Wolf]

Am 28.03.2019 um 19:27 hat Eric Blake geschrieben:
> On 3/28/19 3:20 AM, Vladimir Sementsov-Ogievskiy wrote:
> > 28.03.2019 1:39, Eric Blake wrote:
> >> Add a test for the NBD client workaround in the previous patch.  It's
> >> not really feasible for an iotest to assume a specific tracing engine,
> >> so we can't really probe for the new
> >> trace_nbd_parse_blockstatus_compliance to see if the server was fixed
> >> vs. whether the client just worked around the server (other than by
> >> rearranging order between code patches and this test). But having a
> >> successful exchange sure beats the previous state of an error message.
> >>
> 
> >> +seq="$(basename $0)"
> >> +echo "QA output created by $seq"
> >> +
> >> +status=1 # failure is the default!
> >> +
> >> +nbd_unix_socket=$TEST_DIR/test_qemu_nbd_socket
> >> +rm -f "${TEST_DIR}/qemu-nbd.pid"
> > 
> > hmm, strange that we need to remove something from test directory at start.
> 
> Well, until we follow through with our thread of implementing per-test
> scratch directories for iotests, it proved invaluable to me during
> testing (as a failed test does not properly clean up after itself).

Maybe that's the thing to fix then?

Though I'm not sure why, as you do call nbd_server_stop in _cleanup.
Does this mean that _cleanup wasn't called at all in your failure case?

Kevin

signature.asc
Description: PGP signature