[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.1] target/arm: Stop using variable length
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH for-4.1] target/arm: Stop using variable length array in dc_zva |
Date: |
Fri, 29 Mar 2019 09:18:34 +0000 |
On Thu, 28 Mar 2019 at 19:14, Richard Henderson
<address@hidden> wrote:
>
> On 3/28/19 7:30 AM, Peter Maydell wrote:
> > - void *hostaddr[maxidx];
> > + void *hostaddr[DIV_ROUND_UP(2 * KiB, 1 << TARGET_PAGE_BITS_MIN)];
>
> A very fancy way of writing "2".
Yes, but I thought this made the relationship between the constant
size and what maxidx a little clearer.
>
> > int try, i;
> > unsigned mmu_idx = cpu_mmu_index(env, false);
> > TCGMemOpIdx oi = make_memop_idx(MO_UB, mmu_idx);
> >
> > + assert(maxidx <= sizeof(hostaddr));
>
> ARRAY_SIZE(hostaddr).
Oops, yes.
thanks
-- PMM