[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 7/8] vl: Document dependencies hiding in global and c
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 7/8] vl: Document dependencies hiding in global and compat props |
Date: |
Tue, 2 Apr 2019 15:01:11 +0200 |
Signed-off-by: Markus Armbruster <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
---
vl.c | 24 ++++++++++++++++++++++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 0d517a09e1..c696ad2a13 100644
--- a/vl.c
+++ b/vl.c
@@ -4286,16 +4286,36 @@ int main(int argc, char **argv, char **envp)
current_machine->maxram_size = maxram_size;
current_machine->ram_slots = ram_slots;
+ /*
+ * Note: uses machine properties such as kernel-irqchip, must run
+ * after machine_set_property().
+ */
configure_accelerator(current_machine, argv[0]);
+ /*
+ * Beware, QOM objects created before this point miss global and
+ * compat properties.
+ *
+ * Global properties get set up by qdev_prop_register_global(),
+ * called from user_register_global_props(), and certain option
+ * desugaring. Also in CPU feature desugaring (buried in
+ * parse_cpu_model()), which happens below this point, but may
+ * only target the CPU type, which can only be created after
+ * parse_cpu_model() returned the type.
+ *
+ * Machine compat properties: object_set_machine_compat_props().
+ * Accelerator compat props: object_set_accelerator_compat_props(),
+ * called from configure_accelerator().
+ */
+
if (!qtest_enabled() && machine_class->deprecation_reason) {
error_report("Machine type '%s' is deprecated: %s",
machine_class->name, machine_class->deprecation_reason);
}
/*
- * Migration object can only be created after global properties
- * are applied correctly.
+ * Note: creates a QOM object, must run only after global and
+ * compat properties have been set up.
*/
migration_object_init();
--
2.17.2
- [Qemu-devel] [PULL 0/8] Miscellaneous patches for 2019-04-02, Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 4/8] Revert "vl: Fix to create migration object before block backends again", Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 5/8] Revert "migration: move only_migratable to MigrationState", Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 2/8] qapi/migration.json: Fix ColoStatus member last_mode's version, Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 1/8] vl: Fix error location of positional arguments, Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 7/8] vl: Document dependencies hiding in global and compat props,
Markus Armbruster <=
- [Qemu-devel] [PULL 6/8] migration: Support adding migration blockers earlier, Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 8/8] accel: Unbreak accelerator fallback, Markus Armbruster, 2019/04/02
- [Qemu-devel] [PULL 3/8] qapi/migration.json: Rename COLOStatus last_mode to last-mode, Markus Armbruster, 2019/04/02
- Re: [Qemu-devel] [PULL 0/8] Miscellaneous patches for 2019-04-02, Peter Maydell, 2019/04/02