[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 14/15] char: Make -chardev help print to stdout
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 14/15] char: Make -chardev help print to stdout |
Date: |
Mon, 8 Apr 2019 10:36:26 +0200 |
Command line help explicitly requested by the user should be printed
to stdout, not stderr. We do elsewhere. Adjust -chardev to match:
use qemu_printf() instead of error_printf(). Plain printf() would be
wrong because we need to print to the current monitor for chardev-add
help".
Cc: "Marc-André Lureau" <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
chardev/char.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/chardev/char.c b/chardev/char.c
index 514cd6b0c3..54724a56b1 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -28,6 +28,7 @@
#include "sysemu/sysemu.h"
#include "qemu/config-file.h"
#include "qemu/error-report.h"
+#include "qemu/qemu-print.h"
#include "chardev/char.h"
#include "qapi/error.h"
#include "qapi/qapi-commands-char.h"
@@ -651,7 +652,7 @@ Chardev *qemu_chr_new_from_opts(QemuOpts *opts,
GMainContext *context,
chardev_name_foreach(help_string_append, str);
- error_printf("Available chardev backend types: %s\n", str->str);
+ qemu_printf("Available chardev backend types: %s\n", str->str);
g_string_free(str, true);
return NULL;
}
--
2.17.2
- Re: [Qemu-devel] [PATCH 02/15] block/ssh: Do not report read/write/flush errors to the user, (continued)
- [Qemu-devel] [PATCH 07/15] hpet: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/08
- [Qemu-devel] [PATCH 08/15] vfio: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/08
- [Qemu-devel] [PATCH 15/15] monitor: Simplify how -device/device_add print help, Markus Armbruster, 2019/04/08
- [Qemu-devel] [PATCH 09/15] s390x/kvm: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/08
- [Qemu-devel] [PATCH 14/15] char: Make -chardev help print to stdout,
Markus Armbruster <=
- [Qemu-devel] [PATCH 11/15] monitor error: Make printf()-like functions return a value, Markus Armbruster, 2019/04/08
- [Qemu-devel] [PATCH 06/15] pci: Report fatal errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/08
- [Qemu-devel] [PATCH 13/15] blockdev: Make -drive format=help print to stdout, Markus Armbruster, 2019/04/08