[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/15] mips/boston: Report errors with error_rep
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 05/15] mips/boston: Report errors with error_report(), not error_printf() |
Date: |
Mon, 8 Apr 2019 12:53:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/8/19 10:36 AM, Markus Armbruster wrote:
> Cc: Paul Burton <address@hidden>
> Cc: Aleksandar Rikalo <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/mips/boston.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/mips/boston.c b/hw/mips/boston.c
> index e5bab3cadc..a8b29f62f5 100644
> --- a/hw/mips/boston.c
> +++ b/hw/mips/boston.c
> @@ -528,21 +528,21 @@ static void boston_mach_init(MachineState *machine)
> fw_size = load_image_targphys(machine->firmware,
> 0x1fc00000, 4 * MiB);
> if (fw_size == -1) {
> - error_printf("unable to load firmware image '%s'\n",
> + error_report("unable to load firmware image '%s'",
> machine->firmware);
> exit(1);
> }
> } else if (machine->kernel_filename) {
> fit_err = load_fit(&boston_fit_loader, machine->kernel_filename, s);
> if (fit_err) {
> - error_printf("unable to load FIT image\n");
> + error_report("unable to load FIT image");
> exit(1);
> }
>
> gen_firmware(memory_region_get_ram_ptr(flash) + 0x7c00000,
> s->kernel_entry, s->fdt_base, is_64b);
> } else if (!qtest_enabled()) {
> - error_printf("Please provide either a -kernel or -bios argument\n");
> + error_report("Please provide either a -kernel or -bios argument");
> exit(1);
> }
> }
>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
[Qemu-devel] [PATCH 05/15] mips/boston: Report errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/08
- Re: [Qemu-devel] [PATCH 05/15] mips/boston: Report errors with error_report(), not error_printf(),
Philippe Mathieu-Daudé <=
[Qemu-devel] [PATCH 01/15] qemu-img: Use error_vreport() in error_exit(), Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 10/15] vl: Make -machine $TYPE, help and -accel help print to stdout, Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 04/15] loader-fit: Wean off error_printf(), Markus Armbruster, 2019/04/08
[Qemu-devel] [PATCH 12/15] qemu-print: New qemu_printf(), qemu_vprintf() etc., Markus Armbruster, 2019/04/08