[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RISU PATCH 3/5] risu_reginfo_i386: implement arch-specific
From: |
Jan Bobek |
Subject: |
[Qemu-devel] [RISU PATCH 3/5] risu_reginfo_i386: implement arch-specific reginfo interface |
Date: |
Mon, 8 Apr 2019 14:27:46 -0400 |
CPU-specific code in risu_reginfo_* is expected to define and export
the following symbols:
- arch_long_opts, arch_extra_help, process_arch_opt
- reginfo_size
- reginfo_init
- reginfo_is_eq
- reginfo_dump, reginfo_dump_mismatch
Make risu_reginfo_i386.c implement this interface.
Signed-off-by: Jan Bobek <address@hidden>
---
risu_reginfo_i386.c | 48 +++++++++++++++++++++++++++++++++++++++------
1 file changed, 42 insertions(+), 6 deletions(-)
diff --git a/risu_reginfo_i386.c b/risu_reginfo_i386.c
index e8d671f..3882261 100644
--- a/risu_reginfo_i386.c
+++ b/risu_reginfo_i386.c
@@ -10,12 +10,28 @@
******************************************************************************/
#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
#include <ucontext.h>
#include "risu.h"
#include "risu_reginfo_i386.h"
-static void fill_reginfo(struct reginfo *ri, ucontext_t * uc)
+const struct option * const arch_long_opts;
+const char * const arch_extra_help;
+
+void process_arch_opt(int opt, const char *arg)
+{
+ abort();
+}
+
+const int reginfo_size(void)
+{
+ return sizeof(struct reginfo);
+}
+
+/* reginfo_init: initialize with a ucontext */
+void reginfo_init(struct reginfo *ri, ucontext_t *uc)
{
int i;
for (i = 0; i < NGREG; i++) {
@@ -51,18 +67,38 @@ static void fill_reginfo(struct reginfo *ri, ucontext_t *
uc)
ri->faulting_insn = *((uint32_t *) uc->uc_mcontext.gregs[REG_EIP]);
}
-static char *regname[] = {
+/* reginfo_is_eq: compare the reginfo structs, returns nonzero if equal */
+int reginfo_is_eq(struct reginfo *m, struct reginfo *a)
+{
+ return 0 == memcmp(m, a, sizeof(*m));
+}
+
+static const char *const regname[NGREG] = {
"GS", "FS", "ES", "DS", "EDI", "ESI", "EBP", "ESP",
"EBX", "EDX", "ECX", "EAX", "TRAPNO", "ERR", "EIP",
- "CS", "EFL", "UESP", "SS", 0
+ "CS", "EFL", "UESP", "SS"
};
-static void dump_reginfo(struct reginfo *ri)
+/* reginfo_dump: print state to a stream, returns nonzero on success */
+int reginfo_dump(struct reginfo *ri, FILE *f)
{
int i;
- fprintf(stderr, " faulting insn %x\n", ri->faulting_insn);
+ fprintf(f, " faulting insn %x\n", ri->faulting_insn);
for (i = 0; i < NGREG; i++) {
- fprintf(stderr, " %s: %x\n", regname[i] ? regname[i] : "???",
+ fprintf(f, " %s: %x\n", regname[i] ? regname[i] : "???",
ri->gregs[i]);
}
+ return !ferror(f);
+}
+
+int reginfo_dump_mismatch(struct reginfo *m, struct reginfo *a, FILE *f)
+{
+ int i;
+ for (i = 0; i < NGREG; i++) {
+ if (m->gregs[i] != a->gregs[i]) {
+ fprintf(f, "Mismatch: Register %s\n", regname[i] ? regname[i] :
"???");
+ fprintf(f, "m: [%x] != a: [%x]\n", m->gregs[i], a->gregs[i]);
+ }
+ }
+ return !ferror(f);
}
--
2.20.1
- [Qemu-devel] [RISU PATCH 0/5] Fix RISU build for i386, Jan Bobek, 2019/04/08
- [Qemu-devel] [RISU PATCH 1/5] risu_i386: move reginfo_t and related defines to risu_reginfo_i386.h, Jan Bobek, 2019/04/08
- [Qemu-devel] [RISU PATCH 3/5] risu_reginfo_i386: implement arch-specific reginfo interface,
Jan Bobek <=
- [Qemu-devel] [RISU PATCH 5/5] risu_i386: remove old unused code, Jan Bobek, 2019/04/08
- [Qemu-devel] [RISU PATCH 2/5] risu_i386: move reginfo-related code to risu_reginfo_i386.c, Jan Bobek, 2019/04/08
- [Qemu-devel] [RISU PATCH 4/5] risu_i386: implement missing CPU-specific functions, Jan Bobek, 2019/04/08
- Re: [Qemu-devel] [RISU PATCH 0/5] Fix RISU build for i386, Richard Henderson, 2019/04/08
- Re: [Qemu-devel] [RISU PATCH 0/5] Fix RISU build for i386, Alex Bennée, 2019/04/25