[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.0-maybe] device_tree: Fix integer overflow
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH for-4.0-maybe] device_tree: Fix integer overflowing in load_device_tree() |
Date: |
Thu, 11 Apr 2019 06:31:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Philippe Mathieu-Daudé <address@hidden> writes:
> On 4/10/19 8:34 AM, Alistair Francis wrote:
>> On Tue, Apr 9, 2019 at 10:59 PM Markus Armbruster <address@hidden> wrote:
>>> Philippe Mathieu-Daudé <address@hidden> writes:
>>>> On 4/10/19 7:28 AM, Markus Armbruster wrote:
>>>>> Philippe Mathieu-Daudé <address@hidden> writes:
[...]
>>>>>> BTW how did you figure that out?
>>>>>
>>>>> Downstream handling of upstream commit da885fe1ee8 led me to the
>>>>> function. I spotted dt_size = get_image_size(filename_path).
>>>>> Experience has taught me to check the left hand side's type. Bad. Then
>>>>> I saw how dt_size gets increased. Worse.
>>>>
>>>> So you genuinely neglected to mention Kurtis Miller then :)
>>>
>>> Explanation, not excuse: the only occurence of the name in my downstream
>>> reading was a two-liner BZ comment, which I totally missed in my haste
>>> to give the fix a chance to make 4.0. I certainly didn't mean to
>>> deprive him of credit!
>
> My English teacher explained me neglected sounds like a
> reprimand/reproach (as in negligence), sorry I didn't mean to be rude
> here, I wanted to say something like "Peter remarked you did gave
> credits to the first one who reported this issue, but since you figured
> this bug via your own way, the omission was not intentional then."
Don't worry, my social interactions teacher taught me to assume good
intent ;)
[...]
Re: [Qemu-devel] [PATCH for-4.0-maybe] device_tree: Fix integer overflowing in load_device_tree(), Peter Maydell, 2019/04/09
Re: [Qemu-devel] [PATCH for-4.0-maybe] device_tree: Fix integer overflowing in load_device_tree(), Philippe Mathieu-Daudé, 2019/04/10