[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 12/23] linux-user: Call qcrypto_init if not u
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v3 12/23] linux-user: Call qcrypto_init if not using -seed |
Date: |
Thu, 11 Apr 2019 11:49:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
Hi Richard,
On 3/15/19 4:26 AM, Richard Henderson wrote:
> Cc: Laurent Vivier <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> linux-user/main.c | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index cf7095bdaf..8478306eef 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -38,6 +38,7 @@
> #include "trace/control.h"
> #include "target_elf.h"
> #include "cpu_loop-common.h"
> +#include "crypto/init.h"
>
> char *exec_path;
>
> @@ -686,8 +687,18 @@ int main(int argc, char **argv, char **envp)
> if (seed_optarg == NULL) {
> seed_optarg = getenv("QEMU_RAND_SEED");
> }
> - if (seed_optarg != NULL) {
> - qemu_guest_random_seed_main(seed_optarg, &error_fatal);
> + {
Since 7be41675f7c we use gnu99 C, so this extra block indentation can be
removed.
> + Error *err = NULL;
> + if (seed_optarg != NULL) {
> + qemu_guest_random_seed_main(seed_optarg, &err);
> + } else {
> + /* ??? Assumes qcrypto is only used by qemu_guest_getrandom. */
> + qcrypto_init(&err);
> + }
> + if (err) {
> + error_reportf_err(err, "cannot initialize crypto: ");
> + exit(1);
> + }
> }
>
> target_environ = envlist_to_environ(envlist, NULL);
>
- Re: [Qemu-devel] [PATCH v3 12/23] linux-user: Call qcrypto_init if not using -seed,
Philippe Mathieu-Daudé <=