[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/17] include: Include fprintf-fn.h only where
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 01/17] include: Include fprintf-fn.h only where needed |
Date: |
Fri, 12 Apr 2019 17:53:14 +0100 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
* Markus Armbruster (address@hidden) wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> include/qemu-common.h | 2 --
> include/qemu/cutils.h | 2 --
> include/sysemu/cpus.h | 1 +
> 3 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/include/qemu-common.h b/include/qemu-common.h
> index a102245519..f891e05e7e 100644
> --- a/include/qemu-common.h
> +++ b/include/qemu-common.h
> @@ -12,8 +12,6 @@
> #ifndef QEMU_COMMON_H
> #define QEMU_COMMON_H
>
> -#include "qemu/fprintf-fn.h"
> -
> #define TFR(expr) do { if ((expr) != -1) break; } while (errno == EINTR)
>
> /* Copyright string for -version arguments, About dialogs, etc */
> diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h
> index d2dad3057c..12301340a4 100644
> --- a/include/qemu/cutils.h
> +++ b/include/qemu/cutils.h
> @@ -1,8 +1,6 @@
> #ifndef QEMU_CUTILS_H
> #define QEMU_CUTILS_H
>
> -#include "qemu/fprintf-fn.h"
> -
> /**
> * pstrcpy:
> * @buf: buffer to copy string into
> diff --git a/include/sysemu/cpus.h b/include/sysemu/cpus.h
> index 731756d948..eea0010b53 100644
> --- a/include/sysemu/cpus.h
> +++ b/include/sysemu/cpus.h
> @@ -1,6 +1,7 @@
> #ifndef QEMU_CPUS_H
> #define QEMU_CPUS_H
>
> +#include "qemu/fprintf-fn.h"
> #include "qemu/timer.h"
>
> /* cpus.c */
> --
> 2.17.2
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH 00/17] Clean up and simplify around fprintf_function, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH 02/17] trace: Simplify how st_print_trace_file_status() prints, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH 03/17] tcg: Simplify how dump_opcount_info() prints, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH 05/17] tcg: Simplify how dump_drift_info() prints, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH 01/17] include: Include fprintf-fn.h only where needed, Markus Armbruster, 2019/04/11
- Re: [Qemu-devel] [PATCH 01/17] include: Include fprintf-fn.h only where needed,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH 13/17] qemu-print: New qemu_fprintf(), qemu_vfprintf(), Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH 04/17] tcg: Simplify how dump_exec_info() prints, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH 06/17] qsp: Simplify how qsp_report() prints, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH 12/17] qom/cpu: Simplify how CPUClass::dump_statistics() prints, Markus Armbruster, 2019/04/11
- [Qemu-devel] [PATCH 11/17] target/i386: Simplify how x86_cpu_dump_local_apic_state() prints, Markus Armbruster, 2019/04/11