[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 14/15] char-pty: Print "char device redirected" m
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 14/15] char-pty: Print "char device redirected" message to stdout |
Date: |
Wed, 17 Apr 2019 21:06:40 +0200 |
char_pty_open() prints a "char device redirected to PTY_NAME (label
LABEL)" message to the current monitor or else to stderr. This is not
an error, so it shouldn't go to stderr. Print it to stdout instead.
Why is it even printed? No other ChardevClass::open() prints anything
on success. It's because you need to know PTY_NAME to actually use
this char device, e.g. like e.g. "socat STDIO,cfmakeraw FILE:PTY_NAME"
to use the monitor's readline interface. You can get PTY_NAME with
"info chardev" (a.k.a. query-chardev for QMP), but only if you already
have a monitor.
Signed-off-by: Markus Armbruster <address@hidden>
---
chardev/char-pty.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/chardev/char-pty.c b/chardev/char-pty.c
index b034332edd..04759b0ef9 100644
--- a/chardev/char-pty.c
+++ b/chardev/char-pty.c
@@ -28,6 +28,7 @@
#include "io/channel-file.h"
#include "qemu/sockets.h"
#include "qemu/error-report.h"
+#include "qemu/qemu-print.h"
#include "chardev/char-io.h"
@@ -211,8 +212,8 @@ static void char_pty_open(Chardev *chr,
qemu_set_nonblock(master_fd);
chr->filename = g_strdup_printf("pty:%s", pty_name);
- error_printf("char device redirected to %s (label %s)\n",
- pty_name, chr->label);
+ qemu_printf("char device redirected to %s (label %s)\n",
+ pty_name, chr->label);
s = PTY_CHARDEV(chr);
s->ioc = QIO_CHANNEL(qio_channel_file_new_fd(master_fd));
--
2.17.2
- [Qemu-devel] [PATCH v3 00/15] Clean up use of error_printf(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 04/15] mips/boston: Report errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 14/15] char-pty: Print "char device redirected" message to stdout,
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 09/15] vl: Make -machine $TYPE, help and -accel help print to stdout, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 01/15] qemu-img: Use error_vreport() in error_exit(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 06/15] hpet: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 05/15] pci: Report fatal errors with error_report(), not error_printf(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 12/15] blockdev: Make -drive format=help print to stdout, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 08/15] s390x/kvm: Report warnings with warn_report(), not error_printf(), Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 15/15] monitor: Simplify how -device/device_add print help, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 10/15] monitor error: Make printf()-like functions return a value, Markus Armbruster, 2019/04/17
- [Qemu-devel] [PATCH v3 03/15] loader-fit: Wean off error_printf(), Markus Armbruster, 2019/04/17