Re: [Qemu-devel] [PATCH] target/mips: Amend tests for MSA binary integer operations

[Mateja Marjanovic]

On 17.4.19. 18:41, Aleksandar Markovic wrote:
> > From: Mateja Marjanovic <address@hidden>
> > Subject: [PATCH] target/mips: Amend tests for MSA binary integer operations
> >
> > Amend tests for certain MSA binary integer instructions
> > (for example DIV_S.B) by appending two missing test cases
> > to complete standard battery of 80 test cases for each
> > such instruction. Expected values were pulled from the
> > results of the MIPS64r6 machine that executed those
> > instruction, and QEMU emulation should produce the same
> > results.
> >
> > Signed-off-by: Mateja Marjanovic <address@hidden>
> > ---
> I'm afraid your patch doesn't apply to the tip of the source tree:
>
> $ git am target-mips-Amend-tests-for-MSA-binary-integer-operations.patch 
> Applying: target/mips: Amend tests for MSA binary integer operations
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_add_a_b.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_add_a_b.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_add_a_d.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_add_a_d.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_add_a_h.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_add_a_h.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_add_a_w.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_add_a_w.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_a_b.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_a_b.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_a_d.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_a_d.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_a_h.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_a_h.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_a_w.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_a_w.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_s_b.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_s_b.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_s_d.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_s_d.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_s_h.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_s_h.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_s_w.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_s_w.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_u_b.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_u_b.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_u_d.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_u_d.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_u_h.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_u_h.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_u_w.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_adds_u_w.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_addv_b.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_addv_b.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_addv_d.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_addv_d.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_addv_h.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_addv_h.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_addv_w.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_addv_w.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_s_d.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_s_d.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_s_h.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_s_h.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_s_w.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_s_w.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_u_d.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_u_d.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_u_h.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_u_h.c: patch does not 
> apply
> error: patch failed: tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_u_w.c:2
> error: tests/tcg/mips/user/ase/msa/int-add/test_msa_hadd_u_w.c: patch does not 
> apply
> Patch failed at 0001 target/mips: Amend tests for MSA binary integer operations
> The copy of the patch that failed is found in: .git/rebase-apply/patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
>
> Please update/rebase your tree before sending patches in future.

I will do that from now on.

Thanks,
Mateja

> Thanks,
> Aleksandar