[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/6] acpi: pci: use build_append_foo() API to
From: |
Wei Yang |
Subject: |
Re: [Qemu-devel] [PATCH v3 6/6] acpi: pci: use build_append_foo() API to construct MCFG |
Date: |
Thu, 18 Apr 2019 14:20:58 +0000 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Apr 18, 2019 at 01:02:41PM +0200, Igor Mammedov wrote:
>On Wed, 17 Apr 2019 09:40:38 +0800
>Wei Yang <address@hidden> wrote:
>
>> build_append_foo() API doesn't need explicit endianness conversions
>> which eliminates a source of errors and it makes build_mcfg() look like
>> declarative definition of MCFG table in ACPI spec, which makes it easy
>> to review.
>>
>> Signed-off-by: Wei Yang <address@hidden>
>> Suggested-by: Igor Mammedov <address@hidden>
>Thanks for nice cleanup!
Glad you like it. :-)
>
>with comment fixed up:
>Reviewed-by: Igor Mammedov <address@hidden>
>
>> ---
>> hw/acpi/pci.c | 30 ++++++++++++++++++------------
>> include/hw/acpi/acpi-defs.h | 18 ------------------
>> 2 files changed, 18 insertions(+), 30 deletions(-)
>>
>> diff --git a/hw/acpi/pci.c b/hw/acpi/pci.c
>> index fa0fa30bb9..05050fa087 100644
>> --- a/hw/acpi/pci.c
>> +++ b/hw/acpi/pci.c
>> @@ -30,17 +30,23 @@
>>
>> void build_mcfg(GArray *table_data, BIOSLinker *linker, AcpiMcfgInfo *info)
>> {
>> - AcpiTableMcfg *mcfg;
>> - int len = sizeof(*mcfg) + sizeof(mcfg->allocation[0]);
>> -
>> - mcfg = acpi_data_push(table_data, len);
>> - mcfg->allocation[0].address = cpu_to_le64(info->base);
>> -
>> - /* Only a single allocation so no need to play with segments */
>> - mcfg->allocation[0].pci_segment = cpu_to_le16(0);
>> - mcfg->allocation[0].start_bus_number = 0;
>> - mcfg->allocation[0].end_bus_number = PCIE_MMCFG_BUS(info->size - 1);
>> -
>> - build_header(linker, table_data, (void *)mcfg, "MCFG", len, 1, NULL,
>> NULL);
>> + int mcfg_start = table_data->len;
>> +
>> + acpi_data_push(table_data, sizeof(AcpiTableHeader));
>> +
>> + /* PCI fw r3.0 MCFG table. */
>It would be better to put spec name as is here so simple search
>could immediately point to it.
>
>like: PCI Firmware Specification, Revision 3.0
> 4.1.2 MCFG Table Description
>
Sure, will change to this.
--
Wei Yang
Help you, Help me
- [Qemu-devel] [PATCH v3 0/6] Extract build_mcfg, Wei Yang, 2019/04/16
- [Qemu-devel] [PATCH v3 3/6] i386, acpi: remove mcfg_ prefix in AcpiMcfgInfo members, Wei Yang, 2019/04/16
- [Qemu-devel] [PATCH v3 1/6] q35: acpi: do not create dummy MCFG table, Wei Yang, 2019/04/16
- [Qemu-devel] [PATCH v3 2/6] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start, Wei Yang, 2019/04/16
- [Qemu-devel] [PATCH v3 4/6] hw/arm/virt-acpi-build: pass AcpiMcfgInfo to build_mcfg(), Wei Yang, 2019/04/16
- [Qemu-devel] [PATCH v3 6/6] acpi: pci: use build_append_foo() API to construct MCFG, Wei Yang, 2019/04/16
- [Qemu-devel] [PATCH v3 5/6] hw/acpi: Consolidate build_mcfg to pci.c, Wei Yang, 2019/04/16