[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace()
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace() |
Date: |
Thu, 18 Apr 2019 16:53:50 +0200 |
parse_acl_file() passes char values to isspace(). Undefined behavior
when the value is negative. Not a security issue, because the
characters come from trusted $prefix/etc/qemu/bridge.conf and the
files it includes.
Fix by using qemu_isspace() instead.
Signed-off-by: Markus Armbruster <address@hidden>
---
qemu-bridge-helper.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/qemu-bridge-helper.c b/qemu-bridge-helper.c
index 5396fbfbb6..0d60c07655 100644
--- a/qemu-bridge-helper.c
+++ b/qemu-bridge-helper.c
@@ -29,6 +29,7 @@
#include <linux/if_bridge.h>
#endif
+#include "qemu-common.h"
#include "qemu/queue.h"
#include "net/tap-linux.h"
@@ -75,7 +76,7 @@ static int parse_acl_file(const char *filename, ACLList
*acl_list)
char *ptr = line;
char *cmd, *arg, *argend;
- while (isspace(*ptr)) {
+ while (qemu_isspace(*ptr)) {
ptr++;
}
@@ -99,12 +100,12 @@ static int parse_acl_file(const char *filename, ACLList
*acl_list)
*arg = 0;
arg++;
- while (isspace(*arg)) {
+ while (qemu_isspace(*arg)) {
arg++;
}
argend = arg + strlen(arg);
- while (arg != argend && isspace(*(argend - 1))) {
+ while (arg != argend && qemu_isspace(*(argend - 1))) {
argend--;
}
*argend = 0;
--
2.17.2
- [Qemu-devel] [PATCH 0/6] Fix misuse of ctype.h functions, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PATCH 5/6] pc-bios/s390-ccw: Clean up harmless misuse of isdigit(), Markus Armbruster, 2019/04/18
- [Qemu-devel] [PATCH 3/6] gdbstub: Reject invalid RLE repeat counts, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PATCH 4/6] gdbstub: Fix misuse of isxdigit(), Markus Armbruster, 2019/04/18
- [Qemu-devel] [PATCH 6/6] cutils: Simplify how parse_uint() checks for whitespace, Markus Armbruster, 2019/04/18
- [Qemu-devel] [PATCH 2/6] tests/vhost-user-bridge: Fix misuse of isdigit(), Markus Armbruster, 2019/04/18
- [Qemu-devel] [PATCH 1/6] qemu-bridge-helper: Fix misuse of isspace(),
Markus Armbruster <=