[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qemu-img: Allow rebase with no input base
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qemu-img: Allow rebase with no input base |
Date: |
Thu, 18 Apr 2019 13:55:23 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 7/13/18 6:14 AM, Max Reitz wrote:
> Currently, you cannot add a backing file to an image when it currently
> has none. It is really simple to allow this, though (effectively by
> setting old_backing_size to 0), so this patch does just that.
Can't you do that with 'rebase -u'? I guess the point of this patch is
to make 'rebase' without -u also able to add a backing file? A bit more
clarity in the commit message, such as a sample command line (and
possibly even the error it issued pre-patch) would help.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> qemu-img.c | 61 ++++++++++++++++++++++++++++++------------------------
> 1 file changed, 34 insertions(+), 27 deletions(-)
At any rate, the code looks fine, even if the diff is harder to read
because of added indentation.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 1/3] qemu-img: Allow rebase with no input base,
Eric Blake <=