[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/7] arm: Don't split CPU model string
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH 3/7] arm: Don't split CPU model string |
Date: |
Fri, 19 Apr 2019 03:14:25 -0300 |
CPUClass::class_by_name is called after the CPU model name and
options were already split, there's no need to split the string
again.
Fixes: fb8d6c24b095 ("target-arm: Add CPU property to disable AArch64")
Signed-off-by: Eduardo Habkost <address@hidden>
---
Cc: Greg Bellows <address@hidden>
Cc: Peter Maydell <address@hidden>
Cc: address@hidden
---
target/arm/cpu.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 4155782197..6848d9c94d 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -1212,22 +1212,17 @@ static ObjectClass *arm_cpu_class_by_name(const char
*cpu_model)
{
ObjectClass *oc;
char *typename;
- char **cpuname;
- const char *cpunamestr;
- cpuname = g_strsplit(cpu_model, ",", 1);
- cpunamestr = cpuname[0];
#ifdef CONFIG_USER_ONLY
/* For backwards compatibility usermode emulation allows "-cpu any",
* which has the same semantics as "-cpu max".
*/
- if (!strcmp(cpunamestr, "any")) {
- cpunamestr = "max";
+ if (!strcmp(cpu_model, "any")) {
+ cpu_model = "max";
}
#endif
- typename = g_strdup_printf(ARM_CPU_TYPE_NAME("%s"), cpunamestr);
+ typename = g_strdup_printf(ARM_CPU_TYPE_NAME("%s"), cpu_model);
oc = object_class_by_name(typename);
- g_strfreev(cpuname);
g_free(typename);
if (!oc || !object_class_dynamic_cast(oc, TYPE_ARM_CPU) ||
object_class_is_abstract(oc)) {
--
2.18.0.rc1.1.g3f1ff2140
- [Qemu-devel] [PATCH 0/7] Delete 16 *_cpu_class_by_name() functions, Eduardo Habkost, 2019/04/19
- [Qemu-devel] [PATCH 1/7] cpu: Change return type of cpu_class_by_name() to CPUClass, Eduardo Habkost, 2019/04/19
- [Qemu-devel] [PATCH 2/7] riscv: Don't split CPU model string, Eduardo Habkost, 2019/04/19
- [Qemu-devel] [PATCH 3/7] arm: Don't split CPU model string,
Eduardo Habkost <=
- [Qemu-devel] [PATCH 5/7] cpu: Let architectures set CPU class name format, Eduardo Habkost, 2019/04/19
- [Qemu-devel] [PATCH 4/7] arm: Remove special case for "any" CPU model, Eduardo Habkost, 2019/04/19
- [Qemu-devel] [PATCH 7/7] cpu: Set fixed class name on some architectures, Eduardo Habkost, 2019/04/19
- [Qemu-devel] [PATCH 6/7] cpu: Set class name format for some architectures, Eduardo Habkost, 2019/04/19