[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] tests: fw_cfg: add reboot_timeout test case |
Date: |
Thu, 25 Apr 2019 10:15:19 +0200 |
User-agent: |
NeoMutt/20180716 |
On Wed, Apr 24, 2019 at 09:16:56AM +0800, Li Qiang wrote:
> Thomas Huth <address@hidden> 于2019年4月24日周三 上午12:29写道:
>
> > Is this endianess-safe? Or do you need to byteswap reboot_timeout if the
> > host and guest endianess does not match?
>
> Good question!
>
> IIUC, the qemu fw_cfg store the 'file' entry data just in byte stream.
No. Integers are defined to be little endian. See fw_cfg_add_i64() for
example, there is an explicit cpu_to_le64() call for that.
cheers,
Gerd
[Qemu-devel] [PATCH 4/4] tests: fw_cfg: add splash time test case, Li Qiang, 2019/04/20
[Qemu-devel] [PATCH 2/4] tests: fw_cfg: add a function to get the fw_cfg file, Li Qiang, 2019/04/20