[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 10/21] gdbstub: Implement get register (p pkt) wi
From: |
Jon Doron |
Subject: |
[Qemu-devel] [PATCH v7 10/21] gdbstub: Implement get register (p pkt) with new infra |
Date: |
Fri, 26 Apr 2019 07:35:47 +0300 |
Signed-off-by: Jon Doron <address@hidden>
---
gdbstub.c | 50 ++++++++++++++++++++++++++++++++++++++------------
1 file changed, 38 insertions(+), 12 deletions(-)
diff --git a/gdbstub.c b/gdbstub.c
index 10e3f12a68..e9a3d0c2bc 100644
--- a/gdbstub.c
+++ b/gdbstub.c
@@ -1655,6 +1655,36 @@ static void handle_set_reg(GdbCmdContext *gdb_ctx, void
*user_ctx)
put_packet(gdb_ctx->s, "OK");
}
+static void handle_get_reg(GdbCmdContext *gdb_ctx, void *user_ctx)
+{
+ int reg_size;
+
+ /*
+ * Older gdb are really dumb, and don't use 'g' if 'p' is avaialable.
+ * This works, but can be very slow. Anything new enough to
+ * understand XML also knows how to use this properly.
+ */
+ if (!gdb_has_xml) {
+ put_packet(gdb_ctx->s, "");
+ return;
+ }
+
+ if (!gdb_ctx->num_params) {
+ put_packet(gdb_ctx->s, "E14");
+ return;
+ }
+
+ reg_size = gdb_read_register(gdb_ctx->s->g_cpu, gdb_ctx->mem_buf,
+ gdb_ctx->params[0].val_ull);
+ if (!reg_size) {
+ put_packet(gdb_ctx->s, "E14");
+ return;
+ }
+
+ memtohex(gdb_ctx->str_buf, gdb_ctx->mem_buf, reg_size);
+ put_packet(gdb_ctx->s, gdb_ctx->str_buf);
+}
+
static int gdb_handle_packet(GDBState *s, const char *line_buf)
{
CPUState *cpu;
@@ -1884,18 +1914,14 @@ static int gdb_handle_packet(GDBState *s, const char
*line_buf)
}
break;
case 'p':
- /* Older gdb are really dumb, and don't use 'g' if 'p' is avaialable.
- This works, but can be very slow. Anything new enough to
- understand XML also knows how to use this properly. */
- if (!gdb_has_xml)
- goto unknown_command;
- addr = strtoull(p, (char **)&p, 16);
- reg_size = gdb_read_register(s->g_cpu, mem_buf, addr);
- if (reg_size) {
- memtohex(buf, mem_buf, reg_size);
- put_packet(s, buf);
- } else {
- put_packet(s, "E14");
+ {
+ static const GdbCmdParseEntry get_reg_cmd_desc = {
+ .handler = handle_get_reg,
+ .cmd = "p",
+ .cmd_startswith = 1,
+ .schema = "L0"
+ };
+ cmd_parser = &get_reg_cmd_desc;
}
break;
case 'P':
--
2.20.1
- [Qemu-devel] [PATCH v7 19/21] gdbstub: Implement generic set (Q pkt) with new infra, (continued)
- [Qemu-devel] [PATCH v7 19/21] gdbstub: Implement generic set (Q pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 20/21] gdbstub: Implement target halted (? pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 18/21] gdbstub: Implement generic query (q pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 16/21] gdbstub: Implement step (s pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 15/21] gdbstub: Implement file io (F pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 13/21] gdbstub: Implement write all registers (G pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 12/21] gdbstub: Implement read memory (m pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 08/21] gdbstub: Implement remove breakpoint (z pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 07/21] gdbstub: Implement insert breakpoint (Z pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 05/21] gdbstub: Implement continue with signal (C pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 10/21] gdbstub: Implement get register (p pkt) with new infra,
Jon Doron <=
- [Qemu-devel] [PATCH v7 09/21] gdbstub: Implement set register (P pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 11/21] gdbstub: Implement write memory (M pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 06/21] gdbstub: Implement set_thread (H pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 04/21] gdbstub: Implement continue (c pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 03/21] gdbstub: Implement thread_alive (T pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 02/21] gdbstub: Implement deatch (D pkt) with new infra, Jon Doron, 2019/04/26
- [Qemu-devel] [PATCH v7 01/21] gdbstub: Add infrastructure to parse cmd packets, Jon Doron, 2019/04/26