[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 3/5] block/backup: refactor and tolerate unal
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v6 3/5] block/backup: refactor and tolerate unallocated cluster skipping |
Date: |
Fri, 26 Apr 2019 20:04:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 15.04.19 16:49, Vladimir Sementsov-Ogievskiy wrote:
> Split allocation checking to separate function and reduce nesting.
> Consider bdrv_is_allocated() fail as allocated area, as copying more
> than needed is not wrong (and we do it anyway) and seems better than
> fail the whole job. And, most probably we will fail on the next read,
> if there are real problem with source.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> block/backup.c | 60 +++++++++++++++++++-------------------------------
> 1 file changed, 23 insertions(+), 37 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v6 0/5] backup-top: preparing refactoring, Vladimir Sementsov-Ogievskiy, 2019/04/15
- [Qemu-devel] [PATCH v6 1/5] block/backup: simplify backup_incremental_init_copy_bitmap, Vladimir Sementsov-Ogievskiy, 2019/04/15
- [Qemu-devel] [PATCH v6 4/5] block/backup: unify different modes code path, Vladimir Sementsov-Ogievskiy, 2019/04/15
- [Qemu-devel] [PATCH v6 3/5] block/backup: refactor and tolerate unallocated cluster skipping, Vladimir Sementsov-Ogievskiy, 2019/04/15
- Re: [Qemu-devel] [PATCH v6 3/5] block/backup: refactor and tolerate unallocated cluster skipping,
Max Reitz <=
- [Qemu-devel] [PATCH v6 5/5] block/backup: refactor: split out backup_calculate_cluster_size, Vladimir Sementsov-Ogievskiy, 2019/04/15
- [Qemu-devel] [PATCH v6 2/5] block/backup: move to copy_bitmap with granularity, Vladimir Sementsov-Ogievskiy, 2019/04/15