[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] util/cacheinfo.c: Use uintptr_t instead of
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] util/cacheinfo.c: Use uintptr_t instead of unsigned long in AArch64 arch_cache_info() |
Date: |
Tue, 30 Apr 2019 07:49:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/29/19 2:33 AM, driver1998 wrote:
> Windows ARM64 uses LLP64 model, which breaks current assumptions.
>
> Signed-off-by: driver1998 <address@hidden>
> ---
> util/cacheinfo.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/util/cacheinfo.c b/util/cacheinfo.c
> index 3cd080b83d..a815cb0722 100644
> --- a/util/cacheinfo.c
> +++ b/util/cacheinfo.c
> @@ -107,7 +107,7 @@ static void sys_cache_info(int *isize, int *dsize)
> static void arch_cache_info(int *isize, int *dsize)
> {
> if (*isize == 0 || *dsize == 0) {
> - unsigned long ctr;
> + uintptr_t ctr;
>
> /* The real cache geometry is in CCSIDR_EL1/CLIDR_EL1/CSSELR_EL1,
> but (at least under Linux) these are marked protected by the
> @@ -120,6 +120,8 @@ static void arch_cache_info(int *isize, int *dsize)
> if (*dsize == 0) {
> *dsize = 4 << ((ctr >> 16) & 0xf);
> }
> +
> + printf("%d %d\n", *isize, *dsize);
The patch looks correct (except your real name), but here you forgot to
remove this debugging code.
> }
> }
>
>