Re: [Qemu-devel] [PATCH 09/26] target/m68k: Convert to CPUClass::tlb_fill

[Peter Maydell]

On Wed, 3 Apr 2019 at 04:55, Richard Henderson
<address@hidden> wrote:
>
> Cc: Laurent Vivier <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target/m68k/cpu.h       |  5 ++-
>  target/m68k/cpu.c       |  2 +-
>  target/m68k/helper.c    | 87 ++++++++++++++++++++++-------------------
>  target/m68k/op_helper.c | 15 -------
>  4 files changed, 50 insertions(+), 59 deletions(-)

> @@ -804,11 +791,36 @@ hwaddr m68k_cpu_get_phys_page_debug(CPUState *cs, vaddr 
> addr)
>      return phys_addr;
>  }
>
> -int m68k_cpu_handle_mmu_fault(CPUState *cs, vaddr address, int size, int rw,
> -                              int mmu_idx)
> +/*
> + * Notify CPU of a pending interrupt.  Prioritization and vectoring should
> + * be handled by the interrupt controller.  Real hardware only requests
> + * the vector when the interrupt is acknowledged by the CPU.  For
> + * simplicitly we calculate it when the interrupt is signalled.
> + */

I know this is just code motion, but perhaps we could fix the typo
in passing ("simplicity").

In any case
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM