[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/2] Makefile: add nit-picky mode to sphinx-b
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/2] Makefile: add nit-picky mode to sphinx-build |
|
Date: |
Tue, 30 Apr 2019 18:53:40 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/29/19 5:17 AM, Vladimir Sementsov-Ogievskiy wrote:
> 27.04.2019 1:15, John Snow wrote:
>> If we add references that don't resolve (or accidentally remove them),
>> it will be helpful to have an error message alerting us to that.
>
> the wording still a bit in conflict with the fact that -n is originally a
> warning, not error,
> but I don't really care:
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>
Ah, sorry, I missed that. Not nice to ignore review comments. How about
this:
"If we add references that don't resolve (or accidentally remove them),
it will be helpful to have warning messages alerting us to that.
Further, turn warnings into errors so we can be alerted to these
problems sooner rather than later."
I can fix it in staging. Thank you for your review again.
--js