[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qe
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH v15 1/2] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap() |
|
Date: |
Tue, 30 Apr 2019 19:38:59 -0400 |
On Wed, May 01, 2019 at 01:11:34AM +0200, Paolo Bonzini wrote:
> On 01/05/19 00:50, Michael S. Tsirkin wrote:
> >> Stefan, did you hit a build failure, or it was just theoretical?
> >>
> >> linux-headers/*/mman.h is updated by "linux-headers: add
> >> linux/mman.h" (commit 8cf108c5d159). If the build really fails,
> >> something else is broken in our build system.
> > I think it's for non-linux hosts. linux-headers/ is only used
> > on linux hosts.
>
> Yes, it is. Maybe the #ifndef/#define part should be only used for
> non-Linux.
>
> Paolo
Makes sense. We'd rather have an error on linux than stub it out as 0.
--
MST
[Qemu-devel] [PATCH v15 2/2] docs: Added MAP_SYNC documentation, Wei Yang, 2019/04/25