[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is a
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available |
Date: |
Fri, 3 May 2019 19:04:07 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/3/19 6:41 PM, Thomas Huth wrote:
> On 03/05/2019 02.41, Eduardo Habkost wrote:
>> From: Daniel P. Berrangé <address@hidden>
>>
>> Unless overridden via an env var or configure arg, QEMU will only look
>> for the 'python' binary in $PATH. This is unhelpful on distros which
>> are only shipping Python 3.x (eg Fedora) in their default install as,
>> if they comply with PEP 394, the bare 'python' binary won't exist.
>>
>> This changes configure so that by default it will search for all three
>> common python binaries, preferring to find Python 3.x versions.
>>
>> Signed-off-by: Daniel P. Berrangé <address@hidden>
>> Message-Id: <address@hidden>
>> Signed-off-by: Eduardo Habkost <address@hidden>
>> ---
>> configure | 18 +++++++++++++++---
>> 1 file changed, 15 insertions(+), 3 deletions(-)
>
> I haven't bisected it, but I think this patch here broke the gitlab-ci tests:
>
> https://gitlab.com/huth/qemu/-/jobs/206806257
What's the easier way to notice that automatically?
The quicker fix I have is Peter setup'ing a GitLab account mirroring his
repo:staging branch, and warn him, but that won't scale much.
> Seems like the test is now failing when you don't have an UTF-8 locale:
>
> LANG=C make check-qapi-schema
> [...]
> TEST tests/qapi-schema/union-base-empty.out
> --- /builds/huth/qemu/tests/qapi-schema/unicode-str.err 2019-05-03
> 15:21:39.000000000 +0000
> +++ - 2019-05-03 15:42:01.561762978 +0000
> @@ -1 +1 @@
> -tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name 'é'
> +tests/qapi-schema/unicode-str.json:2: 'command' uses invalid name '\xe9'
> /builds/huth/qemu/tests/Makefile.include:1105: recipe for target
> 'check-tests/qapi-schema/unicode-str.json' failed
> make: *** [check-tests/qapi-schema/unicode-str.json] Error 1
>
> Any ideas how to fix this?
>
> Thomas
>
- [Qemu-devel] [PULL 13/19] tests/boot_linux_console: add a test for mips + malta, (continued)
- [Qemu-devel] [PULL 13/19] tests/boot_linux_console: add a test for mips + malta, Eduardo Habkost, 2019/05/02
- [Qemu-devel] [PULL 15/19] tests/boot_linux_console: add a test for aarch64 + virt, Eduardo Habkost, 2019/05/02
- [Qemu-devel] [PULL 14/19] tests/boot_linux_console: add a test for mips64el + malta, Eduardo Habkost, 2019/05/02
- [Qemu-devel] [PULL 18/19] tests/boot_linux_console: add a test for alpha + clipper, Eduardo Habkost, 2019/05/02
- [Qemu-devel] [PULL 16/19] tests/boot_linux_console: add a test for arm + virt, Eduardo Habkost, 2019/05/02
- [Qemu-devel] [PULL 17/19] tests/boot_linux_console: add a test for s390x + s390-ccw-virtio, Eduardo Habkost, 2019/05/02
- [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available, Eduardo Habkost, 2019/05/02
- Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available, Eduardo Habkost, 2019/05/03
- Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available, Eduardo Habkost, 2019/05/03
- Re: [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available, Thomas Huth, 2019/05/04
Re: [Qemu-devel] [PULL 00/19] Python queue, 2019-05-02, Peter Maydell, 2019/05/03