[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] configure: set source_path only once and
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] configure: set source_path only once and make its definition more robust |
Date: |
Mon, 6 May 2019 12:23:53 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/3/19 3:27 AM, Antonio Ospite wrote:
> From: Antonio Ospite <address@hidden>
>
> Since commit 79d77bcd36 (configure: Remove --source-path option,
> 2019-04-29) source_path cannot be overridden anymore, move it out of the
> "default parameters" block since the word "default" may suggest that the
> value can change, while in fact it does not.
>
> While at it, only set source_path once and separate the positional
> argument of basename with "--" to more robustly cover the case of path
> names starting with a dash.
>
> Signed-off-by: Antonio Ospite <address@hidden>
> ---
> configure | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, (continued)
- [Qemu-devel] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Antonio Ospite, 2019/05/03
- Re: [Qemu-devel] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Eric Blake, 2019/05/06
- Re: [Qemu-devel] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Antonio Ospite, 2019/05/06
- Re: [Qemu-devel] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Peter Maydell, 2019/05/09
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Laurent Vivier, 2019/05/22
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Antonio Ospite, 2019/05/22
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Laurent Vivier, 2019/05/22
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Antonio Ospite, 2019/05/22
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/2] configure: disallow spaces and colons in source path and build path, Laurent Vivier, 2019/05/22
[Qemu-devel] [PATCH v2 1/2] configure: set source_path only once and make its definition more robust, Antonio Ospite, 2019/05/03
- Re: [Qemu-devel] [PATCH v2 1/2] configure: set source_path only once and make its definition more robust,
Eric Blake <=