Re: [Qemu-devel] [PATCH v1 8/8] target/avr: Register AVR support with the rest of QEMU, the build system, and the MAINTAINERS file

[Michael Rolnik]

Yes

Sent from my cell phone, please ignore typos

On Mon, May 6, 2019, 6:11 PM Eric Blake <address@hidden> wrote:

> On 5/4/19 3:36 AM, Sarah Harris wrote:
> > Signed-off-by: Sarah Harris <address@hidden>
> > ---
>
> > +++ b/qapi/common.json
> > @@ -187,7 +187,7 @@
> >  # Since: 3.0
> >  ##
> >  { 'enum' : 'SysEmuTarget',
> > -  'data' : [ 'aarch64', 'alpha', 'arm', 'cris', 'hppa', 'i386', 'lm32',
> > +  'data' : [ 'aarch64', 'alpha', 'arm', 'avr', 'cris', 'hppa', 'i386',
> 'lm32',
> >               'm68k', 'microblaze', 'microblazeel', 'mips', 'mips64',
> >               'mips64el', 'mipsel', 'moxie', 'nios2', 'or1k', 'ppc',
> >               'ppc64', 'riscv32', 'riscv64', 's390x', 'sh4',
>
> Missing documentation that the new 'avr' member is available only since
> 4.1.
>
> > diff --git a/target/avr/Makefile.objs b/target/avr/Makefile.objs
> > new file mode 100644
> > index 0000000000..41355dea1e
> > --- /dev/null
> > +++ b/target/avr/Makefile.objs
> > @@ -0,0 +1,23 @@
> > +#
> > +#  QEMU AVR CPU
> > +#
> > +#  Copyright (c) 2016 Michael Rolnik
>
> Do you want to also claim through 2019?
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org
>
>